Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AcceleratorConnector.root_gpu and deprecate Trainer.root_gpu #12262

Merged
merged 5 commits into from
Mar 19, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Mar 7, 2022

What does this PR do?

Part of #11449: remove unused properties in accelerator_connector: root_gpu
Part of #12171: deprecate device related properties in Trainer in favor of getting them from Trainer.accelerator or Trainer.strategy: root_gpu

AcceleratorConnector.root_gpu was not meant to be public. It's removed from AcceleratorConnector and deprecated in Trainer in favor of using Trainer.strategy.root_device.index if isinstance(Trainer.accelerator, GPUAccelerator) else None

Fixes #11994

Does your PR introduce any breaking changes? If yes, please list them.

N/A

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @four4fish

@ananthsub ananthsub added deprecation Includes a deprecation trainer labels Mar 8, 2022
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 12, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) March 19, 2022 23:15
@awaelchli awaelchli merged commit 5232009 into Lightning-AI:master Mar 19, 2022
@DuYicong515 DuYicong515 deleted the refactor/root_gpu branch March 20, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Trainer.root_gpu
6 participants