-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AcceleratorConnector.root_gpu
and deprecate Trainer.root_gpu
#12262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuYicong515
force-pushed
the
refactor/root_gpu
branch
from
March 7, 2022 22:48
7f533ba
to
97e327e
Compare
DuYicong515
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
justusschock,
kaushikb11 and
rohitgr7
as code owners
March 7, 2022 22:56
four4fish
approved these changes
Mar 7, 2022
ananthsub
approved these changes
Mar 8, 2022
DuYicong515
force-pushed
the
refactor/root_gpu
branch
from
March 8, 2022 06:35
97e327e
to
fe8ac14
Compare
12 tasks
awaelchli
approved these changes
Mar 12, 2022
Borda
approved these changes
Mar 14, 2022
akihironitta
approved these changes
Mar 15, 2022
DuYicong515
force-pushed
the
refactor/root_gpu
branch
from
March 18, 2022 18:08
250eac0
to
1525abe
Compare
DuYicong515
force-pushed
the
refactor/root_gpu
branch
from
March 18, 2022 19:52
98a687c
to
48cf5af
Compare
DuYicong515
force-pushed
the
refactor/root_gpu
branch
from
March 18, 2022 19:53
48cf5af
to
2102197
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11449: remove unused properties in accelerator_connector: root_gpu
Part of #12171: deprecate device related properties in Trainer in favor of getting them from
Trainer.accelerator
orTrainer.strategy
: root_gpuAcceleratorConnector.root_gpu was not meant to be public. It's removed from AcceleratorConnector and deprecated in Trainer in favor of using
Trainer.strategy.root_device.index if isinstance(Trainer.accelerator, GPUAccelerator) else None
Fixes #11994
Does your PR introduce any breaking changes? If yes, please list them.
N/A
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @four4fish