Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable Python 3.10 in full CPU testing #13829

Merged
merged 18 commits into from
Aug 8, 2022
Merged

CI: Enable Python 3.10 in full CPU testing #13829

merged 18 commits into from
Aug 8, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 25, 2022 •
edited
Loading

What does this PR do?

Part of #9980.
Adds Python 3.10 only for "full" cpu testing.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added the ci Continuous Integration label Jul 25, 2022
@akihironitta akihironitta added this to the pl:1.6.x milestone Jul 25, 2022
@akihironitta akihironitta mentioned this pull request Jul 25, 2022
Merged
9 tasks
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.7.x Jul 28, 2022
@akihironitta akihironitta changed the title [wip] CI: Enable Python 3.10 [wip] CI: Enable Python 3.10 in CPU testing Aug 2, 2022
@akihironitta akihironitta marked this pull request as ready for review August 5, 2022 23:58
@akihironitta
Copy link
Contributor Author

Still wip!

@akihironitta akihironitta added the admin Requires admin privileges to merge label Aug 6, 2022
@akihironitta akihironitta changed the title [wip] CI: Enable Python 3.10 in CPU testing CI: Enable Python 3.10 in CPU testing Aug 6, 2022
@akihironitta akihironitta mentioned this pull request Aug 6, 2022
Closed
10 tasks
@akihironitta akihironitta changed the title CI: Enable Python 3.10 in CPU testing CI: Enable Python 3.10 in full CPU testing Aug 6, 2022
@akihironitta akihironitta added the pl Generic label for PyTorch Lightning package label Aug 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 6, 2022
@mergify mergify bot requested a review from a team August 6, 2022 11:11
awaelchli
awaelchli approved these changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news!

@awaelchli awaelchli enabled auto-merge (squash) August 6, 2022 12:16
@awaelchli awaelchli disabled auto-merge August 6, 2022 12:17
@Borda Borda enabled auto-merge (squash) August 8, 2022 08:24
@Borda Borda merged commit 34afde7 into master Aug 8, 2022
@Borda Borda deleted the ci/enable-python3.10 branch August 8, 2022 15:00
rohitgr7 pushed a commit that referenced this pull request Aug 8, 2022
@akihironitta @rohitgr7
CI: Enable Python 3.10 in full CPU testing (#13829)
d9ee6ab 
* Update docker images to build
awaelchli pushed a commit that referenced this pull request Aug 9, 2022
@akihironitta @awaelchli
CI: Enable Python 3.10 in full CPU testing (#13829)
0f195dc 
* Update docker images to build
awaelchli pushed a commit that referenced this pull request Aug 9, 2022
@akihironitta @awaelchli
CI: Enable Python 3.10 in full CPU testing (#13829)
32ca3c9 
* Update docker images to build
lexierule pushed a commit that referenced this pull request Aug 9, 2022
@akihironitta @lexierule
CI: Enable Python 3.10 in full CPU testing (#13829)
431e402 
* Update docker images to build
Borda pushed a commit that referenced this pull request Aug 22, 2022
@akihironitta @Borda
CI: Enable Python 3.10 in full CPU testing (#13829)
57a2c69 
* Update docker images to build

(cherry picked from commit 34afde7)
lantiga pushed a commit that referenced this pull request Aug 22, 2022
@akihironitta @lantiga
CI: Enable Python 3.10 in full CPU testing (#13829)
d6558a6 
* Update docker images to build

(cherry picked from commit 34afde7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton

Assignees

@akihironitta akihironitta

Labels
admin Requires admin privileges to merge ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.
6 participants
@akihironitta @awaelchli @Borda @otaj @carmocca @rohitgr7