Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update tensorboard requirement from <2.10.0,>=2.9.1 to >=2.9.… #14510

Closed
wants to merge 3 commits into from

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 3, 2022

…1,<2.11.0 in /requirements (#14200)"

This reverts commit 401eb2c.

This shows another example of how dependabot update PRs cannot be trusted until we update the docker environments in the PR. The CI in the reverted PR did not use the new upgraded version. Doing so would have shown this error.

Happened already with DeepSpeed: #13048 (comment)

Meant to fix:

Traceback (most recent call last):
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\_pytest\config\__init__.py", line 1638, in parse_warning_filter
Warning: ory: Type[Warning] = _resolve_warning_category(category_)
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\_pytest\config\__init__.py", line 1676, in _resolve_warning_category
    m = __import__(module, None, None, [klass])
  File "D:\a\lightning\lightning\src\pytorch_lightning\__init__.py", line 34, in <module>
    from pytorch_lightning.callbacks import Callback  # noqa: E402
  File "D:\a\lightning\lightning\src\pytorch_lightning\callbacks\__init__.py", line 26, in <module>
    from pytorch_lightning.callbacks.pruning import ModelPruning
  File "D:\a\lightning\lightning\src\pytorch_lightning\callbacks\pruning.py", line 30, in <module>
    from pytorch_lightning.core.module import LightningModule
  File "D:\a\lightning\lightning\src\pytorch_lightning\core\__init__.py", line 16, in <module>
    from pytorch_lightning.core.module import LightningModule
  File "D:\a\lightning\lightning\src\pytorch_lightning\core\module.py", line 40, in <module>
    from pytorch_lightning.loggers import Logger, LoggerCollection
  File "D:\a\lightning\lightning\src\pytorch_lightning\loggers\__init__.py", line 23, in <module>
    from pytorch_lightning.loggers.tensorboard import TensorBoardLogger
  File "D:\a\lightning\lightning\src\pytorch_lightning\loggers\tensorboard.py", line 26, in <module>
    from torch.utils.tensorboard import SummaryWriter
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\torch\utils\tensorboard\__init__.py", line 12, in <module>
    from .writer import FileWriter, SummaryWriter  # noqa: F401
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\torch\utils\tensorboard\writer.py", line 9, in <module>
    from tensorboard.compat.proto.event_pb2 import SessionLog
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\tensorboard\compat\proto\event_pb2.py", line [17](https://github.com/Lightning-AI/lightning/runs/8164093298?check_suite_focus=true#step:20:18), in <module>
    from tensorboard.compat.proto import summary_pb2 as tensorboard_dot_compat_dot_proto_dot_summary__pb2
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\tensorboard\compat\proto\summary_pb2.py", line 17, in <module>
    from tensorboard.compat.proto import tensor_pb2 as tensorboard_dot_compat_dot_proto_dot_tensor__pb2
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\tensorboard\compat\proto\tensor_pb2.py", line 16, in <module>
    from tensorboard.compat.proto import resource_handle_pb2 as tensorboard_dot_compat_dot_proto_dot_resource__handle__pb2
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\tensorboard\compat\proto\resource_handle_pb2.py", line 16, in <module>
    from tensorboard.compat.proto import tensor_shape_pb2 as tensorboard_dot_compat_dot_proto_dot_tensor__shape__pb2
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\tensorboard\compat\proto\tensor_shape_pb2.py", line 42, in <module>
    serialized_options=None, file=DESCRIPTOR),
  File "c:\hostedtoolcache\windows\python\3.7.9\x64\lib\site-packages\google\protobuf\descriptor.py", line 560, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.[19](https://github.com/Lightning-AI/lightning/runs/8164093298?check_suite_focus=true#step:20:20).0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.[20](https://github.com/Lightning-AI/lightning/runs/8164093298?check_suite_focus=true#step:20:21).x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/20[22](https://github.com/Lightning-AI/lightning/runs/8164093298?check_suite_focus=true#step:20:23)-05-06#python-updates

cc @carmocca @akihironitta @Borda

…1,<2.11.0 in /requirements (#14200)"

This reverts commit 401eb2c.
@carmocca carmocca self-assigned this Sep 3, 2022
@carmocca carmocca added the ci Continuous Integration label Sep 3, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Sep 3, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 3, 2022
@carmocca
Copy link
Contributor Author

carmocca commented Sep 3, 2022

Mmm wrong hypothesis. Tensorboard 2.9.1 still failed. Must be from something else

https://github.com/Lightning-AI/lightning/runs/8168742423?check_suite_focus=true#step:16:237

@carmocca carmocca closed this Sep 3, 2022
@carmocca carmocca deleted the ci/revert-tb-update branch September 3, 2022 10:40
@carmocca carmocca mentioned this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants