update docs on checkpoint_callback Trainer argument #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-02 04:01:20 UTC |
awaelchli
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4461 +/- ##
=======================================
+ Coverage 91% 93% +2%
=======================================
Files 113 113
Lines 8397 8192 -205
=======================================
- Hits 7655 7624 -31
+ Misses 742 568 -174 |
awaelchli
requested review from
ananyahjha93,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
SeanNaren
approved these changes
Nov 1, 2020
|
what if both a checkpoint_callback is passed in callbacks and |
|
@rohitgr7 no, because |
|
@awaelchli not always I think. Only if someone passes a ModelCheckpoint explicitly in the callbacks. |
# this is now a warning
Trainer(checkpoint_callback=ModelCheckpoint(...))
# this should not throw a warning, because it is now the recommended way
Trainer(callbacks=[ModelCheckpoint(...)])
# equivalent
Trainer(checkpoint_callback=True (default), callbacks=[ModelCheckpoint(...)]) |
s-rog
approved these changes
Nov 2, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
* docs update * update callbacks docs * docs * notebook examples * warning * line lenght * update deprecation Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Roger Shieh <55400948+s-rog@users.noreply.github.com> (cherry picked from commit 6ae4c6e)
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* docs update * update callbacks docs * docs * notebook examples * warning * line lenght * update deprecation Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Roger Shieh <55400948+s-rog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4446
Adds docs update to deprecation introduced in #4336
PR review