Clarify checkpoint deprecation message #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4640 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 117 117
Lines 9011 9011
=======================================
+ Hits 8134 8384 +250
+ Misses 877 627 -250 |
edenlightning
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Borda
reviewed
Nov 12, 2020
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
I don't think so. This is not a feature. Why shouldn't it be in 1.0.7? |
then the msg does not fit as you say deprecate in 1.1 but you want to release it before 1.1... in such case, we shall rephrase it as deprecated in 1.0.7 and removed in 1.2 |
ydcjeff
approved these changes
Nov 13, 2020
|
Well this is already in 1.0.5? #4336 If so I guess it should be 1.0.5. Altough maybe not super elegant to add deprecations is patch releases :0 |
s-rog
approved these changes
Nov 16, 2020
tchaton
approved these changes
Nov 16, 2020
Borda
reviewed
Nov 20, 2020
Borda
reviewed
Nov 20, 2020
Borda
reviewed
Nov 20, 2020
williamFalcon
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the deprecation message of checkpoint_callback arg clearer. Follow up to #4461