Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.9 #4944

Merged
merged 31 commits into from
Mar 29, 2021
Merged

support python 3.9 #4944

merged 31 commits into from
Mar 29, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 2, 2020

What does this PR do?

includes:

  • testing / CI for 3.9

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects).

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration let's do it! approved to implement Important 3rd party Related to a 3rd-party labels Dec 2, 2020
@Borda Borda added this to the 1.1 milestone Dec 2, 2020
@Borda
Copy link
Member Author

Borda commented Dec 2, 2020

missing wheels for pytorch - pytorch/pytorch#45731

@Borda Borda changed the title support python 3.9 [blocked by PT] support python 3.9 Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #4944 (30614d9) into master (0ea8f39) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4944    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         192     192            
  Lines       12266   12299    +33     
=======================================
- Hits        11178   10675   -503     
- Misses       1088    1624   +536     

@tchaton
Copy link
Contributor

tchaton commented Dec 3, 2020

@Borda Should we close this PR ?

@Borda
Copy link
Member Author

Borda commented Dec 3, 2020

@Borda Should we close this PR ?

Let's keep it as a draft bc it is ready, just need PT to release wheels...

@ydcjeff
Copy link
Contributor

ydcjeff commented Dec 3, 2020

we might need to wait a bit as torchvision and torchtext doesn't have 3.9 build in nightly.

@Borda Borda modified the milestones: 1.1, 1.2 Dec 4, 2020
@Borda Borda changed the title [blocked by PT] support python 3.9 support python 3.9 Dec 13, 2020
@Borda Borda marked this pull request as ready for review December 13, 2020 09:36
@Borda Borda modified the milestones: 1.2, 1.1.x Dec 13, 2020
@Borda
Copy link
Member Author

Borda commented Dec 13, 2020

blocked by microsoft/onnxruntime#6125

@Borda Borda marked this pull request as draft December 13, 2020 22:05
@Borda Borda changed the base branch from master to release/1.2-dev December 20, 2020 07:20
@Borda Borda removed this from the 1.1.x milestone Dec 20, 2020
@Borda
Copy link
Member Author

Borda commented Mar 25, 2021

@tgaddair I have updated PR with master and seems like last failing test are Horovod, mind have look?

FAILED tests/models/test_horovod.py::test_horovod_cpu - assert 1 == 0
FAILED tests/models/test_horovod.py::test_horovod_cpu_implicit - assert 1 == 0

@Borda Borda added Will ready PRs ready to be merged labels Mar 26, 2021
@Borda Borda enabled auto-merge (squash) March 26, 2021 09:34
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@Borda Borda added the admin Requires admin privileges to merge label Mar 26, 2021
@lexierule lexierule disabled auto-merge March 29, 2021 16:20
@lexierule lexierule merged commit 5b5a5cc into master Mar 29, 2021
@lexierule lexierule deleted the add-py3.9 branch March 29, 2021 16:20
@akihironitta akihironitta mentioned this pull request Oct 18, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party admin Requires admin privileges to merge ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants