-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logging on_train_batch_end in a callback with multiple optimizers #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren and
williamFalcon
as code owners
January 15, 2021 00:57
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #5521 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 135 135
Lines 10007 10005 -2
======================================
- Hits 9341 9339 -2
Misses 666 666 |
tchaton
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ananthsub
approved these changes
Jan 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
awaelchli
added
bug
Something isn't working
logging
Related to the `LoggerConnector` and `log()`
labels
Jan 18, 2021
awaelchli
approved these changes
Jan 18, 2021
Borda
pushed a commit
that referenced
this pull request
Feb 4, 2021
…#5521) * Start with the failing test * Then fix the failing test * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
logging
Related to the `LoggerConnector` and `log()`
priority: 0
High priority task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5459
High-level explanation:
Before, we did
range(num_optimizers)
but this fails becauseepoch_metrics
can contain data for just one optimizer.For this reason, the fix is to loop using the
epoch_metrics
keys.list(epoch_metrics)
(to use a copy of the keys) is necessary because keys are deleted inside the loop.Before submitting
PR review