Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More EpochResultStore refactors! 🎉 #5522

Merged
merged 12 commits into from
Feb 11, 2021
Merged

More EpochResultStore refactors! 🎉 #5522

merged 12 commits into from
Feb 11, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 15, 2021

What does this PR do?

Refactoring done while debugging #5521

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5522 (e59c0c3) into release/1.2-dev (774e9bd) will increase coverage by 5%.
The diff coverage is 97%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5522    +/-   ##
================================================
+ Coverage               83%     88%    +5%     
================================================
  Files                  181     181            
  Lines                12929   12742   -187     
================================================
+ Hits                 10771   11236   +465     
+ Misses                2158    1506   -652     

@Borda Borda added the feature Is an improvement or enhancement label Jan 15, 2021
@Borda Borda added this to the 1.2 milestone Jan 15, 2021
@Borda Borda added the refactor label Jan 15, 2021
…sult_store.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor ! Let refactor info a proper structure as recommended by @ananthsub.

@Borda
Copy link
Member

Borda commented Jan 29, 2021

@carmocca mind check the conflicts so we can start review :]

@Borda Borda requested review from ananthsub and Borda February 2, 2021 09:13
@mergify mergify bot removed the has conflicts label Feb 2, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca added the ready PRs ready to be merged label Feb 2, 2021
@mergify mergify bot added the has conflicts label Feb 4, 2021
@mergify mergify bot removed the has conflicts label Feb 4, 2021
@mergify mergify bot added the has conflicts label Feb 6, 2021
@mergify mergify bot removed the has conflicts label Feb 9, 2021
@carmocca carmocca enabled auto-merge (squash) February 10, 2021 23:35
Base automatically changed from release/1.2-dev to master February 11, 2021 14:32
@carmocca carmocca merged commit 9f12ca0 into Lightning-AI:master Feb 11, 2021
@carmocca carmocca deleted the refactor/5459 branch November 14, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants