Fix CometML tests #585
Merged
Fix CometML tests #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why Travis failed. Looks unrelated to the PR. Do we have a way to re-run it? |
There is probably some cache problem #590 |
Lothiraldan
added a commit
to comet-ml/pytorch-lightning
that referenced
this pull request
Jul 8, 2020
The rest_api_key was only used for creating a Comet API object previously used to compute the Logger version based on the number but this was cleaned by Lightning-AI#585 and the code was likely left there.
Lothiraldan
added a commit
to comet-ml/pytorch-lightning
that referenced
this pull request
Jul 8, 2020
The rest_api_key was only used for creating a Comet API object previously used to compute the Logger version based on the number but this was cleaned by Lightning-AI#585 and the code was likely left there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, the CometML tests print a bunch of nasty warning messages because the
comet_mllibrary usesatexit.registerto print a summary. This conflicts with pytest's redirecting of stdout and stderr. More info here: pytest-dev/pytest#5577. Fixed it by monkeypatchingatexit.registerto do nothing.While I was in there, I noticed that the
versionproperty behaves differently than for the other loggers, so I fixed it.