Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent Travis caching #590

Merged
merged 3 commits into from
Dec 7, 2019
Merged

prevent Travis caching #590

merged 3 commits into from
Dec 7, 2019

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 5, 2019

What does this PR do?

As it is now the package installed pip install --editable . and so it is cached so in future it may (it is probably happening right now as it is referring to failing on actually empty line) interfere...
This change performs the package installs in clean virtual env which is removed after all.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda
Copy link
Member Author

Borda commented Dec 6, 2019

@williamFalcon could you restart the CI job...

@Borda Borda mentioned this pull request Dec 7, 2019
@Borda
Copy link
Member Author

Borda commented Dec 7, 2019

@williamFalcon
Copy link
Contributor

ok... how do we get the build to pass?

@williamFalcon williamFalcon merged commit c6e0dbe into Lightning-AI:master Dec 7, 2019
@Borda Borda deleted the travis branch December 7, 2019 15:28
@Borda
Copy link
Member Author

Borda commented Dec 7, 2019

Sure, I will have a look at the minimal versions for Python 3.7
Pls, delete cache from master on Travis

@williamFalcon
Copy link
Contributor

please tell me what i need to do to delete the cache? i don’t have time to look into it this week, so it’s easier to follow steps

@Borda
Copy link
Member Author

Borda commented Dec 7, 2019

image
@williamFalcon top-right menu, select cache and then you'll see list of cached branches...
Delete all or at least master =)

@Borda
Copy link
Member Author

Borda commented Dec 7, 2019

for me the master is fine... https://travis-ci.org/Borda/pytorch-lightning/builds/622102824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants