Docs and Tests for "gpus" Trainer Argument #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I made a mistake, I should have merged master, not rebase. :( |
jeffling
suggested changes
Dec 5, 2019
|
|
||
|
|
||
| @pytest.mark.gpus_param_tests | ||
| @pytest.mark.parametrize(['gpus'], test_parse_gpu_invalid_inputs_data) |
|
@Borda I don't understand the error message from travis. Do you know why it fails to install requirements? |
|
@awaelchli I am going to check it also discussed at #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Updates docs for the
gpusTrainer argument and adds tests for parsing it as discussed in #563.Docs:
I pointed out the difference between gpus=0, gpus=[0] and gpus="0" @jeffling.
Let me know if the column with "Type" is ok or better to be removed.
Tests:
I added tests for all inputs listed in the docs, and also tests for everything else that is not currently supported.
In a follow up PR/Issue, we could discuss the support of the following:
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.