Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v.1.2.6 [full merge, no squash] #6729

Merged
merged 13 commits into from
Mar 30, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 29, 2021

PR review

related to #6083

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the 1.2.x milestone Mar 29, 2021
@carmocca carmocca self-assigned this Mar 29, 2021
@carmocca carmocca mentioned this pull request Mar 29, 2021
@carmocca carmocca changed the title [WIP] Weekly Patch Release v.1.2.6 [full merge, no squash] Weekly Patch Release v.1.2.6 [full merge, no squash] Mar 29, 2021
@Borda
Copy link
Member

Borda commented Mar 30, 2021

shall we include RunIf in this release?
cc: @PyTorchLightning/core-contributors

@carmocca
Copy link
Contributor Author

I don't see why not. It's testing code. Can't even be imported by users.

@SeanNaren
Copy link
Contributor

shall we include RunIf in this release?
cc: @PyTorchLightning/core-contributors

please do, it will make further releases more manageable

awaelchli and others added 13 commits March 30, 2021 14:32
* fix dummy logger

* docs

* update docs

* add changelog

* add none return annotation

* return empty string for name, version
… of train/val/test (#6498)

* update docs

* add hook and update docs

* update tests

* chlog

* Update CHANGELOG.md

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* chlog

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* update coverage config

* parallel

* parallel

* Apply suggestions from code review

* Apply suggestions from code review

* paralel

* paralel

* paralel

* combine

* combine

* .

* ..

* ..

* ..

* rev

* cb

* cb

* drop

* drop

* .

* ..

* ...

* ...

* ...

* .
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
* mock examples

* drop from GA
* Fix checkpoint callback issue for TPUs

* update changelog

* add barrier

* apply code suggestions

* update trainer test

* remove spaces

* fix tpu tests

* Apply suggestions from code review

* add comment

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
…6719)

* update_logic

* update

* Update tests/utilities/test_xla_device_utils.py

* Update pytorch_lightning/utilities/xla_device.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* Update pytorch_lightning/utilities/xla_device.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* update test

* Update tests/utilities/test_xla_device_utils.py

* update

* Apply fix

* Docstring

* flake8

* update

Co-authored-by: Your Name <you@example.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
* use latest

* remake

* examples
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #6729 (fb50a05) into release/1.2.x (cc40fa3) will decrease coverage by 6%.
The diff coverage is 75%.

@@               Coverage Diff               @@
##           release/1.2.x   #6729     +/-   ##
===============================================
- Coverage             93%     87%     -6%     
===============================================
  Files                163     190     +27     
  Lines              11318   13050   +1732     
===============================================
+ Hits               10567   11381    +814     
- Misses               751    1669    +918     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Great work !

@lexierule lexierule merged commit 2ea3ecc into release/1.2.x Mar 30, 2021
@lexierule lexierule deleted the 1.2.6-branch branch March 30, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.