Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename old Trainer.train_loop -> Trainer.fit_loop #8025

Merged
merged 8 commits into from
Jun 22, 2021

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Part of #7938

Resolves a pending todo for renaming the remaining occurrences of the train_loop property which refers to the old training loop construct.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added this to the v1.4 milestone Jun 18, 2021
@awaelchli awaelchli changed the title rename old Trainer.train_loop -> Trainer.fit_loop rename old Trainer.train_loop -> Trainer.fit_loop Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #8025 (c83b96e) into master (dd340a6) will decrease coverage by 0%.
The diff coverage is 95%.

@@          Coverage Diff           @@
##           master   #8025   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13590   13593    +3     
======================================
- Hits        12463   12428   -35     
- Misses       1127    1165   +38     

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

CHANGELOG.md Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jun 18, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 18, 2021 13:48
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 18, 2021
@awaelchli awaelchli mentioned this pull request Jun 21, 2021
11 tasks
@mergify mergify bot removed the has conflicts label Jun 21, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@awaelchli awaelchli merged commit 4becd1c into master Jun 22, 2021
@awaelchli awaelchli deleted the refactor/loops/rename-trainloop-attr branch June 22, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants