-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop Refactor 5/N - Prediction Loop #7700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-23 07:49:52 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7700 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 210 211 +1
Lines 13634 13669 +35
======================================
- Hits 12501 12500 -1
- Misses 1133 1169 +36 |
cool branch name |
justusschock
reviewed
Jun 1, 2021
…TorchLightning/pytorch-lightning into refactor/logger-connector-poc
…TorchLightning/pytorch-lightning into refactor/logger-connector-poc
carmocca
reviewed
Jun 21, 2021
11 tasks
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
carmocca
approved these changes
Jun 22, 2021
pytorch_lightning/loops/dataloader/prediction_dataloader_loop.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/loops/dataloader/prediction_dataloader_loop.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Borda
approved these changes
Jun 23, 2021
for more information, see https://pre-commit.ci
tchaton
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This was originally the full Loop Refactor POC PR which got split up into multiple parts #7871, #7985, #7990, #8056 and what remains now is the prediction loop refactor.
This PR now only contains the Prediction Loop refactors. There are two new classes based on the existing interface in master:
PredictionDataLoaderLoop
: Loops over all dataloaders and for each runs aPredictionEpochLoop
PredictionEpochLoop
: Loops over a single dataloader of prediction batchesAfter merge:
Follow up on TODOs in TODO tracker for ongoing training loop refactors #7938
Related PRs for review: restrict public interface of training loop #8024 , rename old
Trainer.train_loop
->Trainer.fit_loop
#8025Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
co-authored by @justusschock