Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop Refactor 5/N - Prediction Loop #7700

Merged
merged 616 commits into from
Jun 23, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 25, 2021

What does this PR do?

This was originally the full Loop Refactor POC PR which got split up into multiple parts #7871, #7985, #7990, #8056 and what remains now is the prediction loop refactor.

This PR now only contains the Prediction Loop refactors. There are two new classes based on the existing interface in master:

  • PredictionDataLoaderLoop: Loops over all dataloaders and for each runs a PredictionEpochLoop
  • PredictionEpochLoop: Loops over a single dataloader of prediction batches

After merge:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

co-authored by @justusschock

@pep8speaks
Copy link

pep8speaks commented May 25, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-23 07:49:52 UTC

@awaelchli awaelchli added refactor design Includes a design discussion labels May 25, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #7700 (5ca00bd) into master (58b47da) will decrease coverage by 0%.
The diff coverage is 98%.

@@          Coverage Diff           @@
##           master   #7700   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     211    +1     
  Lines       13634   13669   +35     
======================================
- Hits        12501   12500    -1     
- Misses       1133    1169   +36     

@awaelchli awaelchli added the feature Is an improvement or enhancement label May 28, 2021
@Borda
Copy link
Member

Borda commented May 31, 2021

cool branch name refactor/loops_everywhere :D

@mergify mergify bot removed the has conflicts label Jun 22, 2021
awaelchli and others added 2 commits June 22, 2021 16:31
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli and others added 2 commits June 22, 2021 18:47
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@awaelchli awaelchli enabled auto-merge (squash) June 23, 2021 01:53
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 23, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
setup.cfg Show resolved Hide resolved
@justusschock justusschock disabled auto-merge June 23, 2021 07:48
@justusschock justusschock enabled auto-merge (squash) June 23, 2021 07:48
@mergify mergify bot removed the has conflicts label Jun 23, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@justusschock justusschock merged commit a45ab00 into master Jun 23, 2021
@justusschock justusschock deleted the refactor/loops_everywhere branch June 23, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants