-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytorch_lightning.loops
file structure: group by dataloader, epoch, and batch loop
#8077
Conversation
pytorch_lightning.loops
file structure: group by dataloader, epoch, and batch loop
Codecov Report
@@ Coverage Diff @@
## master #8077 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 211 211
Lines 13658 13416 -242
=======================================
- Hits 12512 11803 -709
- Misses 1146 1613 +467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
2f8e0c2
to
9be32de
Compare
for more information, see https://pre-commit.ci
f062a5a
to
9538c65
Compare
self.training_loop = TrainingEpochLoop(min_steps, max_steps) | ||
self.validation_loop = EvaluationDataLoaderLoop() | ||
self.epoch_loop = TrainingEpochLoop(min_steps, max_steps) | ||
self.val_loop = EvaluationLoop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to move this inside the epoch loop as we discussed.
Or do you want to do that in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have it already implemented locally,
there is going to be a circular import due to that, so I would like to discuss the resolution of that in a separate PR.
What does this PR do?
part of #7938
The current structure is the following:
The new proposed file structure:
No deprecations required. The new loops were introduced in master only so far and are for internal use currently.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃