Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop Refactor 6/N - Remove Old Predict Loop #8094

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Follow up to #7700
Removes the old file.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.4 milestone Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #8094 (5ec9c61) into master (a45ab00) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8094    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         211     211            
  Lines       13669   13669            
=======================================
- Hits        12538   11896   -642     
- Misses       1131    1773   +642     

@carmocca carmocca added the ready PRs ready to be merged label Jun 23, 2021
@carmocca carmocca enabled auto-merge (squash) June 23, 2021 11:48
@carmocca carmocca merged commit 4dc08e4 into master Jun 23, 2021
@carmocca carmocca deleted the refactor/loops/remove-old-pred-loop branch June 23, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants