Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation warning after #9901 #9951

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 15, 2021

What does this PR do?

Part of #9939

This was missed in #9901

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor deprecation Includes a deprecation labels Oct 15, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 15, 2021
@carmocca carmocca self-assigned this Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #9951 (1a7773e) into master (6429de8) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9951    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         179     179            
  Lines       15831   15838     +7     
=======================================
+ Hits        14053   14681   +628     
+ Misses       1778    1157   -621     

@four4fish
Copy link
Contributor

Thank you for addressing the issue left from #9901!

@mergify mergify bot added the ready PRs ready to be merged label Oct 15, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton merged commit e5dfdf3 into master Oct 16, 2021
@tchaton tchaton deleted the refactor/avoid-depr-warning-after-9901 branch October 16, 2021 16:36
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants