Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/n] Directly call TrainingTypePlugin APIs instead of going through the Accelerator #9901

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Oct 12, 2021

What does this PR do?

[[1/n] Call training_type_plugin collective functions directly instead of going through the Accelerator]

(#9677)

Fixes #9426

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM !

pytorch_lightning/accelerators/accelerator.py Outdated Show resolved Hide resolved
pytorch_lightning/accelerators/accelerator.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #9901 (08a8785) into master (940b910) will decrease coverage by 4%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #9901    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15745   15770    +25     
=======================================
- Hits        14597   13993   -604     
- Misses       1148    1777   +629     

@four4fish four4fish force-pushed the imp/acce branch 3 times, most recently from f12eb07 to e3c9f22 Compare October 12, 2021 19:37
@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 13, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 13, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Oct 13, 2021
@carmocca carmocca merged commit a002f87 into Lightning-AI:master Oct 14, 2021
carmocca added a commit that referenced this pull request Oct 15, 2021
tchaton pushed a commit that referenced this pull request Oct 16, 2021
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
…the Accelerator (Lightning-AI#9901)

Co-authored-by: tchaton <thomas@grid.ai>
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Directly call TrainingTypePlugin APIs instead of going through the Accelerator
4 participants