Clean up last ModelCheckpoint makedirs call to IOPlugin
#11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
reviewed
Dec 11, 2021
Comment on lines
-1703
to
-1706
| @property | ||
| def should_rank_save_checkpoint(self) -> bool: | ||
| return self.training_type_plugin.should_rank_save_checkpoint | ||
|
|
There was a problem hiding this comment.
since this is publicly exposed, this needs to go through a deprecation process
There was a problem hiding this comment.
noted in summary with context
There was a problem hiding this comment.
thanks for adding the context! i believe the initial removal was incorrect, and we should honor the deprecation process
ananthsub
added
checkpointing
jjenniferdai
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
ananthsub
approved these changes
Dec 13, 2021
awaelchli
approved these changes
Dec 14, 2021
carmocca
approved these changes
Dec 14, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
see comment:
now that we have XLACheckpointIO:
makedirscall inModelCheckpointto IOPluginshould_rank_save_checkpointproperty from Trainer #9433 directly removed trainer propertyshould_rank_save_checkpoint. It was added back in PR [2/n] Directly call TrainingTypePlugin APIs instead of going through the Accelerator #9901, though it's not used anywhere, I think just from a merging issue. This time should we remove or deprecate it?-- if deprecate, definitely separate PR
SingleTPUPlugin.save()which is not used/needed anymore as its functionality moved toXLACheckpointIO.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃