-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable testing with Python 3.10 #1132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
======================================
Coverage 94% 94%
======================================
Files 182 182
Lines 8146 8147 +1
======================================
+ Hits 7653 7654 +1
Misses 493 493 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried a while back too #689, but the challenge here is that not all packages we use for testing have been built for py3.10
ERROR: Failed building wheel for numpy
ERROR: Could not build wheels for numpy, which is required to install pyproject.toml-based projects
Failed to build numpy
The incompatibility between |
Another issue I saw was that all tests failed with Python 3.10 on Windows. The cause should be PyTorch still doesn't support Python 3.10 on Windows.
https://github.com/Lightning-AI/metrics/runs/7273421499?check_suite_focus=true
|
@akihironitta I guess it is ready now, right? |
I'm still waiting for a response in https://discuss.pytorch.org/t/numpy-is-not-available-error/146192/, but we can add Python 3.10 on Windows later as we get an update from them. So, yes, this is ready! |
yes, lets merge it and update later when it is resolved 🐰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! More of a general question:
How many Python versions do we want to keep supporting? All of them until their EOL?
@justusschock @Borda Or until Colab/Kaggle updates the version from 3.7 to 3.8, for example? Found an interesting website which we could utilise: https://pyreadiness.org |
What does this PR do?
Part of Lightning-AI/pytorch-lightning#9980.
TODO:
Update CHANGELOGUpdate docs (if any required)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃