Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable testing with Python 3.10 #1132

Merged
merged 10 commits into from
Jul 11, 2022
Merged

CI: Enable testing with Python 3.10 #1132

merged 10 commits into from
Jul 11, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 9, 2022

What does this PR do?

Part of Lightning-AI/pytorch-lightning#9980.

TODO:

  • Agree on the Python version matrix to test with in CI
  • Update CHANGELOG
  • Update docs (if any required)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • [n/a] Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #1132 (cc079de) into master (412002c) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1132   +/-   ##
======================================
  Coverage      94%     94%           
======================================
  Files         182     182           
  Lines        8146    8147    +1     
======================================
+ Hits         7653    7654    +1     
  Misses        493     493           

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried a while back too #689, but the challenge here is that not all packages we use for testing have been built for py3.10

  ERROR: Failed building wheel for numpy
ERROR: Could not build wheels for numpy, which is required to install pyproject.toml-based projects
Failed to build numpy

@akihironitta
Copy link
Contributor Author

ERROR: Failed building wheel for numpy
ERROR: Could not build wheels for numpy, which is required to install pyproject.toml-based projects
Failed to build numpy

The incompatibility between pypesq and numpy seems no longer an issue as confirmed in CI runs on commit 01c9858.

@akihironitta
Copy link
Contributor Author

Another issue I saw was that all tests failed with Python 3.10 on Windows. The cause should be PyTorch still doesn't support Python 3.10 on Windows.

RuntimeError: Numpy is not available

https://github.com/Lightning-AI/metrics/runs/7273421499?check_suite_focus=true

Currently, PyTorch on Windows only supports Python 3.7-3.9; Python 2.x is not supported.

.github/workflows/ci_integrate.yml Outdated Show resolved Hide resolved
.github/workflows/ci_docker.yml Outdated Show resolved Hide resolved
.github/workflows/ci_test-full.yml Outdated Show resolved Hide resolved
.github/workflows/publish-docker.yml Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Jul 11, 2022

@akihironitta I guess it is ready now, right?

@akihironitta akihironitta changed the title [wip] CI: Enable testing with Python 3.10 CI: Enable testing with Python 3.10 Jul 11, 2022
@akihironitta
Copy link
Contributor Author

I'm still waiting for a response in https://discuss.pytorch.org/t/numpy-is-not-available-error/146192/, but we can add Python 3.10 on Windows later as we get an update from them.

So, yes, this is ready!

@Borda Borda enabled auto-merge (squash) July 11, 2022 13:43
@Borda
Copy link
Member

Borda commented Jul 11, 2022

I'm still waiting for a response in https://discuss.pytorch.org/t/numpy-is-not-available-error/146192/, but we can add Python 3.10 on Windows later as we get an update from them.

yes, lets merge it and update later when it is resolved 🐰

Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! More of a general question:

How many Python versions do we want to keep supporting? All of them until their EOL?

.github/workflows/ci_integrate.yml Outdated Show resolved Hide resolved
@Borda Borda merged commit 17014b7 into master Jul 11, 2022
@Borda Borda deleted the ci/enable-python3.10 branch July 11, 2022 14:35
@mergify mergify bot added the ready label Jul 11, 2022
@Borda Borda mentioned this pull request Jul 11, 2022
4 tasks
@akihironitta
Copy link
Contributor Author

akihironitta commented Jul 12, 2022

How many Python versions do we want to keep supporting? All of them until their EOL?

@justusschock @Borda Or until Colab/Kaggle updates the version from 3.7 to 3.8, for example?


Found an interesting website which we could utilise: https://pyreadiness.org
(I found it via https://stackoverflow.com/questions/70714622/why-is-colab-still-running-python-3-7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants