Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PL 1.8 #910

Merged
merged 13 commits into from
Nov 1, 2022
Merged

Support PL 1.8 #910

merged 13 commits into from
Nov 1, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 22, 2022 •
edited by Borda
Loading

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Borda
Borda reviewed Oct 27, 2022
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Oct 27, 2022

@rohitgr7, how is it going here? :)

@rohitgr7 rohitgr7 mentioned this pull request Oct 27, 2022
Closed
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Oct 27, 2022 •
edited
Loading

@Borda
tests are good now. Only 2 ci blockers:

  1. Lightning 1.8 release. Since we shouldn't keep rc in requirements.
  2. Probably broken docker images Lightning-AI/pytorch-lightning#15368 which is causing a ci failure.

@akihironitta
Copy link
Contributor

akihironitta commented Oct 28, 2022 •
edited
Loading

There're two failures in Bolts' GPU CI blocking this PR:

cc @rohitgr7

@rohitgr7
Copy link
Contributor Author

@akihironitta not sure about the second one because it's failing locally too.. let's see. I have re-ran the tests there

This was referenced Oct 28, 2022
Closed
Merged
@rohitgr7 rohitgr7 self-assigned this Oct 31, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review November 1, 2022 17:07
akihironitta
akihironitta approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready label Nov 1, 2022
@Borda Borda merged commit 49ba008 into master Nov 1, 2022
@Borda Borda deleted the ref/pl_18 branch November 1, 2022 18:30
@Borda Borda mentioned this pull request Nov 2, 2022
Merged
8 tasks
@awaelchli awaelchli mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@akihironitta akihironitta akihironitta approved these changes

@otaj otaj Awaiting requested review from otaj

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

@rohitgr7 rohitgr7

Labels
callback model ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitgr7 @Borda @akihironitta @awaelchli