Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min PL as 1.7 #930

Merged
merged 10 commits into from
Nov 2, 2022
Merged

set min PL as 1.7 #930

merged 10 commits into from
Nov 2, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 2, 2022

What does this PR do?

Reaction to #910

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

.github/workflows/ci-tests.yml Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Nov 2, 2022

@Borda
Copy link
Member Author

Borda commented Nov 2, 2022

Seems there is some issue with installing onnx on py3.10

@otaj
Copy link
Contributor

otaj commented Nov 2, 2022

I'm on it

@Borda Borda mentioned this pull request Nov 2, 2022
8 tasks
@otaj
Copy link
Contributor

otaj commented Nov 2, 2022

sparseml is forcing old onnx version, which would require compilation from source on 3.10 in the CI. We won't be doing that, so for now CI runs on 3.7 and 3.9 :sadpanda:

@Borda Borda enabled auto-merge (squash) November 2, 2022 11:05
@mergify mergify bot added the ready label Nov 2, 2022
@Borda Borda merged commit c2552c7 into master Nov 2, 2022
@Borda Borda deleted the pkg/pl-1.7 branch November 2, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants