Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

expose scheduler to Task #189

Closed
wants to merge 12 commits into from
Closed

expose scheduler to Task #189

wants to merge 12 commits into from

Conversation

aniketmaurya
Copy link
Contributor

What does this PR do?

#175

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #189 (84d4d91) into master (4a2aa47) will decrease coverage by 0.04%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   86.53%   86.48%   -0.05%     
==========================================
  Files          57       57              
  Lines        2732     2737       +5     
==========================================
+ Hits         2364     2367       +3     
- Misses        368      370       +2     
Flag Coverage Δ
unittests 86.48% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 93.56% <87.50%> (-0.41%) ⬇️
flash/text/seq2seq/core/data.py 81.96% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2aa47...84d4d91. Read the comment docs.

flash/core/model.py Outdated Show resolved Hide resolved
flash/core/model.py Outdated Show resolved Hide resolved
flash/core/model.py Outdated Show resolved Hide resolved
flash/core/model.py Outdated Show resolved Hide resolved
flash/core/model.py Outdated Show resolved Hide resolved
aniketmaurya and others added 4 commits April 13, 2021 00:46
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
@pep8speaks
Copy link

pep8speaks commented Apr 12, 2021

Hello @aniketmaurya! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-12 19:34:55 UTC

@aribornstein
Copy link
Contributor

@ethanwharris @tchaton @aniketmaurya is there any progress here?

@tchaton
Copy link
Contributor

tchaton commented Apr 21, 2021

Dear @aniketmaurya,

Awesome work with this PR. I took some inspirations from it and finish it in this PR: #232.

Closing this one.
Best,
T.C

@tchaton tchaton closed this Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants