-
Notifications
You must be signed in to change notification settings - Fork 212
[feat] Add serve #399
[feat] Add serve #399
Conversation
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2021-06-11 16:52:58 UTC |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 89.82% 84.78% -5.05%
==========================================
Files 80 109 +29
Lines 4217 6591 +2374
==========================================
+ Hits 3788 5588 +1800
- Misses 429 1003 +574
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major change I suggest is on the naming of FlashServeModel
to just Serve
. It's more elegant and in-line with other project naming conventions, i.e. Task
.
What does this PR do?
This PR add serve functionalities to Flash.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃