Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sel method #339

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Add sel method #339

merged 2 commits into from
Feb 22, 2023

Conversation

MarcoGorelli
Copy link

@MarcoGorelli MarcoGorelli commented Feb 22, 2023 •
edited
Loading

@MarcoGorelli MarcoGorelli requested a review from khider February 22, 2023 14:26
khider
khider approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@khider khider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: tolerance for datetime. I wonder if we should make it a %tolerance for all. As in 2% tolerance.

@khider khider merged commit 8883511 into LinkedEarth:Development Feb 22, 2023
CommonClimate
CommonClimate reviewed Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add a docstring with an example of use, and set a higher tolerance default than 0

@CommonClimate CommonClimate mentioned this pull request Feb 23, 2023
Closed
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommonClimate CommonClimate CommonClimate left review comments

@khider khider khider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @khider @CommonClimate