Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let .sel take tolerance for datetime or str time #349

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

MarcoGorelli
Copy link

follow up to #339

@MarcoGorelli MarcoGorelli requested a review from khider February 27, 2023 21:21
@khider
Copy link
Member

khider commented Mar 1, 2023

@MarcoGorelli The examples use days for the tolerance. Is it possible to do it with years (I know we had to create something like this for resample) or we're stuck with the "highest" pandas units?

@MarcoGorelli
Copy link
Author

It's that the standard library timedelta only has years as the highest unit https://docs.python.org/3/library/datetime.html#datetime.timedelta

I think it's because 'years' wouldn't be a fixed amount of time

@khider khider merged commit 6ffc422 into LinkedEarth:Development Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants