alternative way of getting volume name on Mac OS X <10.7 #3
Conversation
|
This builds without warnings on 10.6, and mocha reports |
|
Forgot to say that I used |
| desc = MYCFStringGetV8String(CFErrorCopyDescription(error)); | ||
| #else | ||
| CFStringRef errorString = CFSTR("Could not get volume name from FSRef."); | ||
| desc = MYCFStringGetV8String(errorString); |
There was a problem hiding this comment.
desc = String::New("Could not get volume name from FSRef.")?
There was a problem hiding this comment.
Well, yes.
Should I add a new commit to the branch or --amend this one?
|
I'll have a look at this later tonight, but it looks good |
kCFURLVolumeNameKey was introduced in 10.7.
|
Sorry, some things got in the way yesterday. I'll do it tonight. |
|
I wrote this into a separate file, with better error reporting, and added some tests. Could you please check out my master and test if it works okay. I'll add you as a contributor to the package.json if you want to. Name, email, url? |
|
Builds without warnings, passes 3
That would be nice, thanks! |
|
Yeah, I didn't really know what to do with the volume name. But that's great, I'll push a release to |
kCFURLVolumeNameKey was introduced in 10.7.