Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a build error using GCC or Apple-provided Clang on Mac OS 10.6 #4

Merged
merged 1 commit into from
Apr 26, 2014

Conversation

dliessi
Copy link
Contributor

@dliessi dliessi commented Apr 25, 2014

See issue #2.

The error was expected constructor, destructor, or type conversion before ‘<’ token and happened on Mac OS 10.6 with GCC and Clang from Xcode 3.2.6 and with GCC (at least) 4.7 and 4.8 provided by MacPorts; Clang 3.4 provided by MacPorts didn't have this problem.

I got a hint in the right direction from the error message of GCC 4.8 from MacPorts, that said reference to 'Handle' is ambiguous.

I tested the change with the mentioned compilers: they built without warnings, except for Clang from Xcode 3.2.6, which gave the warning clang: warning: not using the clang compiler for C++ inputs; with mocha all of them passed 3 tests and failed the volume name test the same way as described in #3 (comment), so they actually passed all tests.

@LinusU
Copy link
Owner

LinusU commented Apr 26, 2014

Super, I was just about to comment and ask you if we could try and solve this. I'll publish the new version within 5 mins

LinusU added a commit that referenced this pull request Apr 26, 2014
addon: fix build error on older OS X
@LinusU LinusU merged commit 9623ab4 into LinusU:master Apr 26, 2014
@LinusU
Copy link
Owner

LinusU commented Apr 26, 2014

@dliessi Just published the new version, you should be able to do npm install appdmg now, could you please test?

@dliessi dliessi deleted the issue2.1 branch April 26, 2014 23:24
@dliessi
Copy link
Contributor Author

dliessi commented Apr 26, 2014

you should be able to do npm install appdmg now

Indeed, I was able to install appdmg. I'll test if it works as expected in the next days.

Actually for the project I'm working on I may need the ability to include arbitrary files in the DMG (i.e. LinusU/node-appdmg#16), so for the time being I may decide to use dmgbuild (mentioned in LinusU/node-appdmg#14 (comment)).
Anyway, I'm interested in appdmg, and I'll keep an eye on it. :)

@LinusU
Copy link
Owner

LinusU commented Apr 27, 2014

Version 0.1.12 of appdmg supports extra files, I just pushed it to npm, please let me know if it works out for you :)

@dliessi
Copy link
Contributor Author

dliessi commented Apr 27, 2014

Version 0.1.12 of appdmg supports extra files, I just pushed it to npm, please let me know if it works out for you :)

That was so quick! :)
I'll test as soon as possible.

@dliessi
Copy link
Contributor Author

dliessi commented May 7, 2014

Version 0.1.12 of appdmg supports extra files, I just pushed it to npm, please let me know if it works out for you :)

Just tested, works as expected.
Again, many thanks!

@dliessi
Copy link
Contributor Author

dliessi commented May 7, 2014

Just tested, works as expected.

Well, not exactly, see LinusU/node-appdmg#33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants