some extra files are not placed at the specified coordinates

[dliessi]

This seems to depend on the file name: e.g. an empty ChangeLog file is placed ignoring Xpos and Ypos, while the same empty file renamed to DangeLog is placed at the specified coordinates.

[LinusU]

Could it have something to do with the length of the name? Could you please try 1ChangeLog, ChangeLog, hangeLog and angeLog...

[dliessi]

I tried different combinations of 1ChangeLog, ChangeLog, hangeLog, angeLog:

• if angeLog was present, it was wrongly placed and also the application was wrongly placed;
• all other combinations of 1ChangeLog, ChangeLog, hangeLog were correctly placed;
• when I added a README file to 1ChangeLog, ChangeLog and hangeLog, the placement of hangeLog was wrong, while the other files were correctly placed.

[dliessi]

Some more examples (you can see also examples of issue #32).
All files have exactly the same content and the same attributes (creation and modified times, permissions, ownership).
The difference between examples with the same number of extra files is only the name of the included files.

2 extra files, correctly placed:

2 extra files, wrongly placed:

3 extra files, correctly placed:

3 extra files, wrongly placed:

4 extra files, correctly placed:

4 extra files, wrongly placed:

[dliessi]

[In case you're wondering, Pippo is the Italian name of Goofy and is one of the most used metasyntactic variable names in Italian, usually accompanied by Pluto and Paperino (= Donald Duck). :) ]

[LinusU]

Hehe, nice trivia :)

I have very little time at the moment but will try to look at this more within a week. I think that it might have something to do with the ordering in the ds-store file. If you have more time to test, try and see if you can find a link between the alphabetical ordering of the files and the breakage. I remember that the entries had to be ordered in a specific order for the file to be valid, maybe I made a misstake there.

[LinusU]

Hmm, the entries are sorted but maybe the sorting is wrong.

https://github.com/LinusU/node-ds-store/blob/master/lib/ds-store.js#L278

[dliessi]

If you have more time to test, try and see if you can find a link between the alphabetical ordering of the files and the breakage.

I was short of time the last days, but tomorrow morning I should be able to do some more tests.

[jschmidt42]

I have the same issue here, as soon as I use spaces in my file name I get some icons being misplaced.

In the example above, if I change "Project Scotty.app" to "ProjectScotty.app" I get proper placement.

Here is my spec:

{
"title": "M&E Cloud Services",
"app": "Project Scotty.app",
"background": "ScottyMacInstaller.png",
"icon": "Scotty.icns",

"icons": {
"size": 80,
"app": [158, 184],
"alias": [400, 184]
},

"extra": [
["ash.mod", 158, 350],
["readme.txt", 555, 275]
]
}

[dliessi]

I did some tests.
I noticed that extra files are misplaced if their name comes before the application name or the Applications folder name in alphabetical order.
(Numbers apparently are sorted after letters, for what concerns this problem: in my tests files with names beginning with a number were always placed correctly.)
Sometimes also the application icon and the Applications folder icon are misplaced if some extra files are misplaced, but I didn't notice any regularities in this.

I couldn't reproduce what @jschmidt42 describes: I get the same wrong placement of the icons both with and without the space in the application name.

Maybe the localCompares at https://github.com/LinusU/node-ds-store/blob/master/lib/entry.js#L38 need some options.
I tried some changes, but they were ineffective.
But I actually don't know what I'm doing. :D

@LinusU Any ideas?

[LinusU]

This is now fixed in 0.1.13 thanks to @dliessi :)