Add priority field to loaded resources for fine-grained load ordering
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should just be there for information purposes. Can also be misleading if user thinks `rla_page` is used to delete and not the hidden `rla_id`.
FO-nTTaX
reviewed
Apr 13, 2024
Co-authored-by: Alex Winkler <FO-nTTaX@users.noreply.github.com>
iMarbot
changed the title
priority field to loaded resources for fine-grinded load orderingpriority field to loaded resources for fine-grained load ordering
hjpalpha
reviewed
Apr 13, 2024
Explain the load order - higher loaded first
hjpalpha
reviewed
Apr 13, 2024
Also added separating header rows in the special page between scripts and styles.
1 task
FO-nTTaX
requested changes
Apr 15, 2024
Co-authored-by: Alex Winkler <FO-nTTaX@users.noreply.github.com>
|
Idk how I didn't see |
That's why we have code review :P |
FO-nTTaX
reviewed
Apr 15, 2024
Co-authored-by: Alex Winkler <FO-nTTaX@users.noreply.github.com>
iMarbot
commented
Apr 15, 2024
Co-authored-by: Martin B <mvbotev@yahoo.co.uk>
FO-nTTaX
approved these changes
Apr 16, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed previously in the Lua & Commons Resources repo, adding priority field to RLA extension so that we can order them based on more than just alphabetical order.
Also disabled editing the form fields on the delete form.
How did you test this change?
Untested as I don't have a test wiki. Please test before merging.