Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] About the contributing #497

Closed
Singebob opened this issue Feb 18, 2022 · 5 comments
Closed

[FEEDBACK] About the contributing #497

Singebob opened this issue Feb 18, 2022 · 5 comments
Labels
🌈 Feedback [ISSUE] Tell us what you think of the project 🕸️ Inactive

Comments

@Singebob
Copy link
Contributor

Hello,
First of all, thank you for this great project 👍
In the development part you talk about NVM and Gitpod, but in the repo there is no config file for these two tools, which in my opinion is not practical.
Nvm allows contributors to have the same versions of Node and Yarn that you use. ( I couldn't find the exact versions 😢 )
Gitpod allows the contributor to have a development environment very quickly to help you with the configuration you want
Would it be possible to add these two configuration files to facilitate the contribution to your project?

Disclaimer: Sorry for my english 😭

@Singebob Singebob added the 🌈 Feedback [ISSUE] Tell us what you think of the project label Feb 18, 2022
@liss-bot

This comment was marked as off-topic.

@Lissy93 Lissy93 reopened this Feb 19, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Feb 19, 2022

Hey @Singebob,
Absolutely, I can add configuration files for those platforms, it's a good idea :)

In the meantime, you can find the GitPod, and CodeSpaces links in the readme, and the node version in the package.json

Open Project in VS Code Open in GitPod Open in GitHub Code Spaces

dashy/package.json

Lines 67 to 69 in 2e63da0

"engines": {
"node": ">=16.0.0"
},

@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Mar 22, 2022
@liss-bot
Copy link
Collaborator

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Mar 27, 2022
Lissy93 added a commit that referenced this issue Mar 28, 2022
[FEATURE] Implementing user suggestions
This PR resolves loads of tickets... Fixes #492, fixes #494, fixes #497, fixes #505, fixes #522, fixes #524, fixes #546, fixes #552, fixes #554, fixes #560, fixes #564, fixes #568, fixes #570, fixes #575 and fixes #576 - Yay 🥳
Celebrating getting out of hospital with 15 bug fixes 🐛 and a beer 🍺
@Lissy93
Copy link
Owner

Lissy93 commented Mar 28, 2022

Hiya @Singebob,
I've added a .gitpod.yml in #557 / V 2.0.6
Let me know how you get on with that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌈 Feedback [ISSUE] Tell us what you think of the project 🕸️ Inactive
Projects
None yet
Development

No branches or pull requests

3 participants