Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid parameter passed to WSASendMsg() #2890

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jul 19, 2024

Description

Trivial fix for an invalid parameter we have been passing to WSASendMsg(). I must have had sendmmsg() on the mind when I was writing this because the third parameter is dwFlags not the count of WSAMSG. 1 is MSG_OOB which is invalid for a UDP socket, but apparently we get lucky and WSASendMsg() just ignores it.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 19, 2024 00:40
The second parameter is for flags, not number of messages.
@cgutman cgutman disabled auto-merge July 19, 2024 08:05
@cgutman cgutman enabled auto-merge (squash) July 19, 2024 08:05
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.19%. Comparing base (3935d30) to head (f2768d5).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2890   +/-   ##
======================================
  Coverage    9.19%   9.19%           
======================================
  Files          97      97           
  Lines       17523   17523           
  Branches     8331    8331           
======================================
  Hits         1611    1611           
+ Misses      13085   13084    -1     
- Partials     2827    2828    +1     
Flag Coverage Δ
Linux 6.96% <ø> (ø)
Windows 4.51% <0.00%> (ø)
macOS-12 10.31% <ø> (+0.01%) ⬆️
macOS-13 10.22% <ø> (+0.01%) ⬆️
macOS-14 10.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/platform/windows/misc.cpp 2.17% <0.00%> (ø)

... and 1 file with indirect coverage changes

@cgutman cgutman merged commit 0ca560c into LizardByte:master Jul 19, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant