-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wayland capture on nvidia for kms #884
Conversation
Your PR was set to |
I confirm this works great and I can stream from Wayland now. The performance of KMS + Wayland is a bit disappointing compared to x11+nvfbc. I can only reach ~85fps instead of 120fps even though the encoder isn't working very hard and mouse/keyboard are very laggy. It's probably just nvidia's fault. |
+1 Streaming now actually works on wayland + nvidia without any issues. I don't go over 60FPS so I can't vouch for the performance of higher FPS but that's probably due to KMS and not due to this patch |
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#649, in PR LizardByte#884.
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
…y_ram_t" This reverts commit ebe01ce. Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884. This also adds a comment so hopefully it doesn't get removed again in the future (or a proper fix is found).
Description
Following #649, I added the same code for
kmsgrub
which from my testing works pretty wellIssues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.