fix: type issues by using correct import #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
|
1 similar comment
|
Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
|
|
Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
|
DhruvArora-03
changed the title
doprz
requested changes
Feb 27, 2024
doprz
approved these changes
Feb 28, 2024
Comment on lines
+4
to
+16
| import AutoLoad from '@views/components/injected/AutoLoad/AutoLoad'; | ||
| import CourseCatalogInjectedPopup from '@views/components/injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup'; | ||
| import RecruitmentBanner from '@views/components/injected/RecruitmentBanner/RecruitmentBanner'; | ||
| import TableHead from '@views/components/injected/TableHead'; | ||
| import TableRow from '@views/components/injected/TableRow/TableRow'; | ||
| import TableSubheading from '@views/components/injected/TableSubheading/TableSubheading'; | ||
| import { useKeyPress } from '@views/hooks/useKeyPress'; | ||
| import useSchedules from '@views/hooks/useSchedules'; | ||
| import { CourseCatalogScraper } from '@views/lib/CourseCatalogScraper'; | ||
| import getCourseTableRows from '@views/lib/getCourseTableRows'; | ||
| import type { SiteSupportType } from '@views/lib/getSiteSupport'; | ||
| import { populateSearchInputs } from '@views/lib/populateSearchInputs'; | ||
| import ExtensionRoot from '@views/components/common/ExtensionRoot/ExtensionRoot'; |
There was a problem hiding this comment.
Great job, this is much cleaner.
|
|
||
| interface Props { | ||
| support: typeof SiteSupport.COURSE_CATALOG_DETAILS | typeof SiteSupport.COURSE_CATALOG_LIST; | ||
| support: Extract<SiteSupportType, 'COURSE_CATALOG_DETAILS' | 'COURSE_CATALOG_LIST'>; |
doprz
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix: use StatusType * fix: use AutoLoadStatus * fix: use typof SiteSupport.* * fix: one more of Status to StatusType * fix: use import type * fix: use path alias imports * fix: use Extract * fix: remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced Status with StatusType, AutoLoadStatus with AutoLoadStatusType, and I added "typeof" in front of SiteSupport to fix another type error. Not too sure about that last one, I couldn't get it to work with SiteSupportType since we specifically want either of the 2 options.