Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type issues by using correct import #111

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/views/components/CourseCatalogMain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { useKeyPress } from '../hooks/useKeyPress';
import useSchedules from '../hooks/useSchedules';
import { CourseCatalogScraper } from '../lib/CourseCatalogScraper';
import getCourseTableRows from '../lib/getCourseTableRows';
import type { SiteSupport } from '../lib/getSiteSupport';
import type { SiteSupport, SiteSupportType } from '../lib/getSiteSupport';
DhruvArora-03 marked this conversation as resolved.
Show resolved Hide resolved
import { populateSearchInputs } from '../lib/populateSearchInputs';
import ExtensionRoot from './common/ExtensionRoot/ExtensionRoot';
import AutoLoad from './injected/AutoLoad/AutoLoad';
Expand All @@ -17,7 +17,7 @@ import TableRow from './injected/TableRow/TableRow';
import TableSubheading from './injected/TableSubheading/TableSubheading';

interface Props {
support: SiteSupport.COURSE_CATALOG_DETAILS | SiteSupport.COURSE_CATALOG_LIST;
support: typeof SiteSupport.COURSE_CATALOG_DETAILS | typeof SiteSupport.COURSE_CATALOG_LIST;
DhruvArora-03 marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Status } from '@shared/types/Course';
import { Status, StatusType } from '@shared/types/Course';
import Text from '@views/components/common/Text/Text';
import clsx from 'clsx';
import React from 'react';
Expand All @@ -15,7 +15,7 @@ import CancelledIcon from '~icons/material-symbols/warning';
export interface CalendarCourseCellProps {
courseDeptAndInstr: string;
timeAndLocation?: string;
status: Status;
status: StatusType;
colors: CourseColors;
className?: string;
}
Expand All @@ -27,7 +27,7 @@ export interface CalendarCourseCellProps {
* @param {CalendarCourseCellProps} props - The component props.
* @param {string} props.courseDeptAndInstr - The course department and instructor.
* @param {string} props.timeAndLocation - The time and location of the course.
* @param {Status} props.status - The status of the course.
* @param {StatusType} props.status - The status of the course.
* @param {Colors} props.colors - The colors for styling the cell.
* @param {string} props.className - Additional CSS class name for the cell.
* @returns {JSX.Element} The rendered component.
Expand Down
4 changes: 2 additions & 2 deletions src/views/components/common/CourseStatus/CourseStatus.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Status } from '@shared/types/Course';
import type { StatusType } from '@shared/types/Course';
import { StatusIcon } from '@shared/util/icons';
import clsx from 'clsx';
import React from 'react';
Expand All @@ -11,7 +11,7 @@ type SizeType = 'small' | 'mini';
* Props for CourseStatus
*/
export interface CourseStatusProps {
status: Status;
status: StatusType;
size: SizeType;
}

Expand Down
3 changes: 2 additions & 1 deletion src/views/components/injected/AutoLoad/AutoLoad.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { CourseCatalogScraper } from '@views/lib/CourseCatalogScraper';
import { SiteSupport } from '@views/lib/getSiteSupport';
import {
AutoLoadStatus,
AutoLoadStatusType,
DhruvArora-03 marked this conversation as resolved.
Show resolved Hide resolved
loadNextCourseCatalogPage,
removePaginationButtons,
} from '@views/lib/loadNextCourseCatalogPage';
Expand All @@ -22,7 +23,7 @@ type Props = {
*/
export default function AutoLoad({ addRows }: Props) {
const [container, setContainer] = useState<HTMLDivElement | null>(null);
const [status, setStatus] = useState<AutoLoadStatus>(AutoLoadStatus.IDLE);
const [status, setStatus] = useState<AutoLoadStatusType>(AutoLoadStatus.IDLE);
DhruvArora-03 marked this conversation as resolved.
Show resolved Hide resolved

useEffect(() => {
const portalContainer = document.createElement('div');
Expand Down
4 changes: 2 additions & 2 deletions src/views/lib/CourseCatalogScraper.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { InstructionMode, ScrapedRow, Semester } from '@shared/types/Course';
import type { InstructionMode, ScrapedRow, Semester, StatusType } from '@shared/types/Course';
import { Course, Status } from '@shared/types/Course';
import { CourseSchedule } from '@shared/types/CourseSchedule';
import Instructor from '@shared/types/Instructor';
Expand Down Expand Up @@ -278,7 +278,7 @@ export class CourseCatalogScraper {
* @param row the row of the course catalog table
* @returns
*/
getStatus(row: HTMLTableRowElement): [status: Status, isReserved: boolean] {
getStatus(row: HTMLTableRowElement): [status: StatusType, isReserved: boolean] {
const div = row.querySelector(TableDataSelector.STATUS);
if (!div) {
throw new Error('Status not found');
Expand Down
Loading