Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting for Storybook #615

Closed
mrdavidburns opened this issue Jul 18, 2024 · 2 comments · Fixed by #613
Closed

Fix linting for Storybook #615

mrdavidburns opened this issue Jul 18, 2024 · 2 comments · Fixed by #613
Assignees
@mrdavidburns

Comments

@mrdavidburns
Copy link
Member

No description provided.

@mrdavidburns mrdavidburns mentioned this issue Jul 18, 2024
Merged
@elvism-lullabot
Copy link
Collaborator

@mrdavidburns @deviantintegral
not sure if this branch/commit could help here 0b8aa9b

@mrdavidburns mrdavidburns self-assigned this Jul 26, 2024
@deviantintegral
Copy link
Member

@elvism-lullabot we have a PR open at #613 for this.

I think both are substantially similar, though the PR handles any docroot (and not just web) and is conditional within the same command.

@justafish justafish mentioned this issue Aug 8, 2024
Merged
justafish added a commit that referenced this issue Aug 13, 2024
@justafish
Issue #638: Updates for Drupal 11 (#639)
84d3711 
- Replace sserbin/twig-linter with vincentlanglet/twig-cs-fixer/ - sserbin/twig-linter depends on an old version of symfony/console and core is adopting this new package at some point https://www.drupal.org/project/drupal/issues/3284817 - it also has a much better extension mechanism which will help if something like Fix linting for Storybook #615 comes up again
- Update Pantheon settings for Drupal 11
- Update PHPUnit configurations and tests for Drupal 11
- Fix mysterious yarn issues with DDEV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrdavidburns mrdavidburns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(twig): support storybook twig extension in linting bronzehedwick/drainpipe
3 participants
@deviantintegral @mrdavidburns @elvism-lullabot