Issue #638: Fix all our tests #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
justafish
commented
Aug 8, 2024
•
justafish
commented
- Replace sserbin/twig-linter with vincentlanglet/twig-cs-fixer/ - sserbin/twig-linter depends on an old version of symfony/console and core is adopting this new package at some point https://www.drupal.org/project/drupal/issues/3284817 - it also has a much better extension mechanism which will help if something like Fix linting for Storybook #615 comes up again
- Update Pantheon settings for Drupal 11
- Update PHPUnit configurations and tests for Drupal 11
- Fix mysterious yarn issues with DDEV
|
You've buried the lede here with "Drupal 11 compatibility"! |
deviantintegral
approved these changes
Aug 9, 2024
| ddev exec npm i -g yarn@1.22.1 | ||
| ddev exec 'ln -s $(npm root -g)/yarn/bin/yarn /usr/local/bin/yarn' | ||
| ddev exec yarn init -y | ||
| ddev exec yarn add focus-trap@^6.7.3 |
There was a problem hiding this comment.
what's this package for? Is it just an easy way to do a test?
There was a problem hiding this comment.
It's testing whether the package import works correctly when bundling
|
|
||
| include: | ||
| - php-version: 8.1 | ||
| drupal-version: ":^10" |
Comment on lines
-41
to
+43
| $this->assertEquals(REQUEST_TIME, $user->getCreatedTime(), 'Creating a user sets default "created" timestamp.'); | ||
| $this->assertEquals(REQUEST_TIME, $user->getChangedTime(), 'Creating a user sets default "changed" timestamp.'); | ||
| $this->assertEquals($request_time, $user->getCreatedTime(), 'Creating a user sets default "created" timestamp.'); | ||
| $this->assertEquals($request_time, $user->getChangedTime(), 'Creating a user sets default "changed" timestamp.'); |
mrdavidburns
added a commit
to Lullabot/drainpipe-test
that referenced
this pull request
Aug 12, 2024
|
@deviantintegral I've made some tweaks to make it compatible with both D10 and D11. I don't think we need to bump to v4 as the twig linter wasn't configurable previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.