Implement blue light filters #1065
Conversation
|
I just noticed that the LUT gets reset when waking up from standby. |
sysmodules/rosalina/rosalina.rsf
Outdated
| @@ -50,8 +50,12 @@ AccessControlInfo: | |||
| # The kernel extension removes svc perms checks, so below is just to avoid a makerom error | |||
| Backdoor: 123 | |||
| KernelSetState: 124 | |||
| BindInterrupt: 80 | |||
There was a problem hiding this comment.
This isn't really used, see above comment
| do { | ||
| u32 pos = idx & 0xFF; | ||
|
|
||
| GPU_FB_TOP_COL_LUT_INDEX = pos; |
There was a problem hiding this comment.
You only need to set the index once. It increases automatically on each write.
ghost
deleted a comment from
|
Sorry for having not reviewed it yet, will do later |
|
Did it get reviewed? I want to try this. |
|
When rebased against the latest commit and built, rosalina's menu no longer opens after setting a filter. Dunno if that happened initially, but its something that needs to be resolved before this can be merged. |
|
I'll have a look at it again (but it may take a few weeks). |
|
Sorry for the very long delay, was busy with other stuff, the code seems totally fine. Maybe the bug is due to the fact that the menu stack size was not actually bumped (in the array declaration), will check later. EDIT: yep it's that & I have it working now |
sizeof(menuThreadStack) not matching 0x3000
Implement blue light filters
This change is