php artisan lychee:sync failing with Unresolvable dependency resolving bool $enableCLIFormatting #1319

mederel · 2022-05-09T19:21:23Z

Getting the following exception:

Unresolvable dependency resolving [Parameter #1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec

when running:

php artisan lychee:sync myfolder

nagmat84 · 2022-05-09T20:18:07Z

I am not sure, if I like the change, because IMHO there is no sensible default whether CLI formatting should be enabled or not. If at all, then the default should be false, because the method is also used internally for HTTP request.

However, I am not sure, why you get this error at all. I cannot reproduce it and there are only exactly two places places where the constructor is invoked.

In app/Console/Commands/Sync.php at

Lychee/app/Console/Commands/Sync.php

Lines 83 to 92 in 7a0c791

    
           $exec = new Exec( 
        
           	new ImportMode( 
        
           		$deleteImported, 
        
           		$this->option('import_via_symlink') === '1', 
        
           		$importViaSymlink, 
        
           		$this->option('resync_metadata') 
        
           	), 
        
           	true, 
        
           	0 
        
           );

In app/Actions/Import/FromServer.php at

Lychee/app/Actions/Import/FromServer.php

Line 20 in 7a0c791

$exec = new Exec($importMode, false, $this->determineMemLimit());

In both cases, the 2nd parameter is given. Are you sure that your working directory is clean and that you don't have a modified app/Console/Commands/Sync.php?

nagmat84 · 2022-05-09T22:23:58Z

Oh, sorry my fault. The true error is in this line

Lychee/app/Console/Commands/Sync.php

Line 64 in 7a0c791

public function handle(Exec $exec): int

If you want, could you revert your previous commit and remove the parameter Exec $exec from the method handle? That is the actual reason why it fails.

The code

         /** 
          * Execute the console command. 
          * 
          * @param Exec $exec 
          * 
          * @return int 
          * 
          * @throws ExternalLycheeException 
          */ 
         public function handle(Exec $exec): int

should be

         /** 
          * Execute the console command. 
          * 
          * @return int 
          * 
          * @throws ExternalLycheeException 
          */ 
         public function handle(): int

mederel · 2022-05-09T22:56:52Z

Oh, sorry my fault. The true error is in this line

Lychee/app/Console/Commands/Sync.php

Line 64 in 7a0c791

public function handle(Exec $exec): int

If you want, could you revert your previous commit and remove the parameter Exec $exec from the method handle? That is the actual reason why it fails.

The code
         /** 
          * Execute the console command. 
          * 
          * @param Exec $exec 
          * 
          * @return int 
          * 
          * @throws ExternalLycheeException 
          */ 
         public function handle(Exec $exec): int
should be
         /** 
          * Execute the console command. 
          * 
          * @return int 
          * 
          * @throws ExternalLycheeException 
          */ 
         public function handle(): int

Changes applied. Honestly thank you so much for your diligence!!!

app/Console/Commands/Sync.php

nagmat84 · 2022-05-10T00:37:03Z

No problem. Does it work now?

mederel · 2022-05-10T08:41:51Z

No problem. Does it work now?

I have to test tonight. Will update here.

…g bool $enableCLIFormatting fixes LycheeOrg#1318 Getting the following exception: ``` Unresolvable dependency resolving [Parameter LycheeOrg#1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec ``` when running: ``` php artisan lychee:sync myfolder ```