Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizes images if Imagick extension is missing #1

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

hermzz
Copy link
Contributor

@hermzz hermzz commented Dec 2, 2018

If the Imagick extension isn't installed $error = false and the backup
GD resizing doesn't get run. Photo::createMedium still returns true so
the medium (and small) flags get set in the DB.

If the Imagick extension isn't installed `$error = false` and the backup
GD resizing doesn't get run. `Photo::createMedium` still returns true so
the medium (and small) flags get set in the DB.
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted ! Thanks.

@ildyria ildyria merged commit 4b4ea06 into LycheeOrg:master Dec 2, 2018
@hermzz hermzz deleted the imagick-image-resize branch February 2, 2019 21:49
@padregeek padregeek mentioned this pull request Jul 4, 2020
@gdureuil gdureuil mentioned this pull request Jan 20, 2022
mederel added a commit to mederel/Lychee that referenced this pull request May 9, 2022
…g bool $enableCLIFormatting

fixes LycheeOrg#1318

Getting the following exception:

```
Unresolvable dependency resolving [Parameter LycheeOrg#1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec
```

when running:

```
php artisan lychee:sync myfolder
```
mederel added a commit to mederel/Lychee that referenced this pull request May 10, 2022
…g bool $enableCLIFormatting

fixes LycheeOrg#1318

Getting the following exception:

```
Unresolvable dependency resolving [Parameter LycheeOrg#1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec
```

when running:

```
php artisan lychee:sync myfolder
```
nagmat84 pushed a commit that referenced this pull request May 10, 2022
…g bool $enableCLIFormatting (#1319)

Fixes #1318

Getting the following exception:

```
Unresolvable dependency resolving [Parameter #1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec
```

when running:

```
php artisan lychee:sync myfolder
```
@sunosv sunosv mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants