-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizes images if Imagick extension is missing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Imagick extension isn't installed `$error = false` and the backup GD resizing doesn't get run. `Photo::createMedium` still returns true so the medium (and small) flags get set in the DB.
ildyria
approved these changes
Dec 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted ! Thanks.
Closed
Closed
mederel
added a commit
to mederel/Lychee
that referenced
this pull request
May 9, 2022
…g bool $enableCLIFormatting fixes LycheeOrg#1318 Getting the following exception: ``` Unresolvable dependency resolving [Parameter LycheeOrg#1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec ``` when running: ``` php artisan lychee:sync myfolder ```
mederel
added a commit
to mederel/Lychee
that referenced
this pull request
May 10, 2022
…g bool $enableCLIFormatting fixes LycheeOrg#1318 Getting the following exception: ``` Unresolvable dependency resolving [Parameter LycheeOrg#1 [ <required> bool $enableCLIFormatting ]] in class App\Actions\Import\Exec ``` when running: ``` php artisan lychee:sync myfolder ```
Closed
This was referenced Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Imagick extension isn't installed
$error = false
and the backupGD resizing doesn't get run.
Photo::createMedium
still returns true sothe medium (and small) flags get set in the DB.