Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 bucket support. #2379

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Add S3 bucket support. #2379

merged 5 commits into from
Apr 26, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 11, 2024

No description provided.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Apr 11, 2024
ildyria and others added 4 commits April 12, 2024 21:54
@ildyria
avoid sending things to s3 as soon as the key is set
56ecd47
@ildyria
[Stacked 2] Add Enum storage. (#2380)
804f568 
* [Stacked 3] Add storage disk to Size Variants. (#2381)
* [Stacked 4] Refactor deletion (#2382)
* [Stacked 5] Remove local requirement Middleware (#2383)
* [Stacked 6] Remove hard coded values from naming strategy (#2384)
* [Stacked 7] Finally upload the data to S3 (#2385)
@ildyria
Merge branch 'master' into feature-s3
b9482f4
@ildyria
fix phpstan
3ff7708
@ildyria ildyria changed the title [Stacked 1] Add features flag for s3 Add S3 bucket support. Apr 26, 2024
@ildyria ildyria merged commit 01e1f00 into master Apr 26, 2024
31 checks passed
@ildyria ildyria deleted the feature-s3 branch April 26, 2024 15:29
@Kovah
Copy link
Contributor

Kovah commented Apr 29, 2024

@ildyria It's sad to be not even mentioned a bit for the early contributions and testing of the feature. I spent days working on this. After this experience, I will never contribute again to Lychee in the future.

ed2

@d7415
Copy link
Contributor

d7415 commented Apr 29, 2024

@Kovah I think that was an oversight (possibly automated). The release notes on the website were written (by ildyria) to credit you.

@ildyria
Copy link
Member Author

ildyria commented Apr 29, 2024 •
edited
Loading

@Kovah I literally made sure that you were in the git history while doing the squash merge.
image
and also added you (before you complained) in the release as above mentioned by @d7415 (see time stamp of the commit in the branch).

The release notes of the github are automated.
I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @Kovah @d7415