[Stacked 7] Finally upload the data to S3 #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: medium
ildyria
force-pushed
the
refactor-naming-strategy
branch
from
5cff814 to
418d9b3
Compare
ildyria
force-pushed
the
s3-uploading-step
branch
from
e587b75 to
f382e56
Compare
|
@Kovah could you check this PR if this is working for s3 ? Pretty please. You will need to set those in your PHOTO_PIPES=true
S3_ENABLED=true
AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_DEFAULT_REGION=
AWS_BUCKET=
AWS_URL=
AWS_ENDPOINT=
AWS_IMAGE_VISIBILITY=
AWS_USE_PATH_STYLE_ENDPOINT= |
d7415
approved these changes
Apr 23, 2024
ildyria
added a commit
that referenced
this pull request
Apr 24, 2024
* [Stacked 7] Finally upload the data to S3 (#2385)
ildyria
added a commit
that referenced
this pull request
Apr 24, 2024
ildyria
added a commit
that referenced
this pull request
Apr 24, 2024
ildyria
added a commit
that referenced
this pull request
Apr 24, 2024
ildyria
added a commit
that referenced
this pull request
Apr 26, 2024
* [Stacked 1] Add features flag for s3 (#2379) * [Stacked 2] Add Enum storage. (#2380) * [Stacked 3] Add storage disk to Size Variants. (#2381) * [Stacked 4] Refactor deletion (#2382) * [Stacked 5] Remove local requirement Middleware (#2383) * [Stacked 6] Remove hard coded values from naming strategy (#2384) * [Stacked 7] Finally upload the data to S3 (#2385) Co-authored-by: Kovah <mail@kovah.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.