-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacked 4: Fix error message : details on upload #2566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: easy
Easy review expected: probably just need a quick to go through.
label
Oct 18, 2024
ildyria
force-pushed
the
fix-error-message-upload
branch
from
October 23, 2024 10:29
276c604
to
1d7aef4
Compare
ildyria
changed the title
Fix error message details upload
Stacked 4: Fix error message : details on upload
Oct 23, 2024
ildyria
added
Review: easy
Easy review expected: probably just need a quick to go through.
and removed
Review: easy
Easy review expected: probably just need a quick to go through.
labels
Oct 23, 2024
d7415
approved these changes
Oct 24, 2024
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568) * Stacked 7: Clear create album name on creation/move (#2569) * Stacked 8: Fix visibility not updating when traversing albums (#2570) * Stacked 9: Remove redundant auth check query (#2572) * Stacked 10: Add footer also in albums and album (#2571) * Stacked 11: Fix VueJs not usable in sub folders. (#2573) * Staked 12: Fix qr code not working (#2576) * Stacked 13: Statistics per album (#2577) * Stacked 14: Allow to chose the photo layout per album (#2575) * Stacked 15: Show owner instead of just Shared albums (#2574) * Stacked 16: Composer update + fixing phpstan / Ts checker (#2580) * Stacked 17: Various fixes. (#2581) --------- Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria
added a commit
that referenced
this pull request
Oct 26, 2024
* Stacked 4: Fix error message : details on upload (#2566) * Stacked 5: Fix visibility updated wrong message (#2567) * Stacked 6: Fix styling of left menu per @d7415 request :D (#2568) * Stacked 7: Clear create album name on creation/move (#2569) * Stacked 8: Fix visibility not updating when traversing albums (#2570) * Stacked 9: Remove redundant auth check query (#2572) * Stacked 10: Add footer also in albums and album (#2571) * Stacked 11: Fix VueJs not usable in sub folders. (#2573) * Staked 12: Fix qr code not working (#2576) * Stacked 13: Statistics per album (#2577) * Stacked 14: Allow to chose the photo layout per album (#2575) * Stacked 15: Show owner instead of just Shared albums (#2574) * Stacked 16: Composer update + fixing phpstan / Ts checker (#2580) * Stacked 17: Various fixes. (#2581) --------- Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria
added a commit
that referenced
this pull request
Oct 26, 2024
* Stacked 3: fix play icon not showing on images (#2579) * Stacked 4: Fix error message : details on upload (#2566) * Stacked 5: Fix visibility updated wrong message (#2567) * Stacked 6: Fix styling of left menu per @d7415 request :D (#2568) * Stacked 7: Clear create album name on creation/move (#2569) * Stacked 8: Fix visibility not updating when traversing albums (#2570) * Stacked 9: Remove redundant auth check query (#2572) * Stacked 10: Add footer also in albums and album (#2571) * Stacked 11: Fix VueJs not usable in sub folders. (#2573) * Staked 12: Fix qr code not working (#2576) * Stacked 13: Statistics per album (#2577) * Stacked 14: Allow to chose the photo layout per album (#2575) * Stacked 15: Show owner instead of just Shared albums (#2574) * Stacked 16: Composer update + fixing phpstan / Ts checker (#2580) * Stacked 17: Various fixes. (#2581) --------- Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria
added a commit
that referenced
this pull request
Oct 26, 2024
* Stacked 2: Fix sharing - add icon to indicate read access (#2564) * Stacked 3: fix play icon not showing on images (#2579) * Stacked 4: Fix error message : details on upload (#2566) * Stacked 5: Fix visibility updated wrong message (#2567) * Stacked 6: Fix styling of left menu per @d7415 request :D (#2568) * Stacked 7: Clear create album name on creation/move (#2569) * Stacked 8: Fix visibility not updating when traversing albums (#2570) * Stacked 9: Remove redundant auth check query (#2572) * Stacked 10: Add footer also in albums and album (#2571) * Stacked 11: Fix VueJs not usable in sub folders. (#2573) * Staked 12: Fix qr code not working (#2576) * Stacked 13: Statistics per album (#2577) * Stacked 14: Allow to chose the photo layout per album (#2575) * Stacked 15: Show owner instead of just Shared albums (#2574) * Stacked 16: Composer update + fixing phpstan / Ts checker (#2580) * Stacked 17: Various fixes. (#2581) --------- Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On feedback from @tinohager
Added improved error message when upload is crashing instead of just a blank red line.