Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked 7: Clear create album name on creation/move #2569

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 19, 2024

Small issue I found today.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 19, 2024
@ildyria ildyria added this to the 6.0.0 milestone Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 67.93893% with 42 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (1315293) to head (25ab806).
Report is 2 commits behind head on left-menu-styling.

Additional details and impacted files

@ildyria ildyria changed the title Clear album name once it is created/when changing parent Stacked 7: Clear create album name on creation/move Oct 23, 2024
@ildyria ildyria changed the base branch from v6 to left-menu-styling October 23, 2024 10:35
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
@ildyria ildyria merged commit 8ad6c98 into left-menu-styling Oct 26, 2024
46 checks passed
@ildyria ildyria deleted the create-album-fix branch October 26, 2024 01:42
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 5: Fix visibility updated wrong message (#2567)
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 4: Fix error message : details on upload (#2566)
* Stacked 5: Fix visibility updated wrong message (#2567)
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 3: fix play icon not showing on images (#2579)
* Stacked 4: Fix error message : details on upload (#2566)
* Stacked 5: Fix visibility updated wrong message (#2567)
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
ildyria added a commit that referenced this pull request Oct 26, 2024
* Stacked 2: Fix sharing - add icon to indicate read access (#2564)
* Stacked 3: fix play icon not showing on images (#2579)
* Stacked 4: Fix error message : details on upload (#2566)
* Stacked 5: Fix visibility updated wrong message (#2567)
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants