-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inital commit of tedana package #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning of class-style refactoring to ease up the global shenanigans going on in `tedana.py`. Created a MultiEchoData class (`interfaces/data.py`) to hold input multi-echo data, echo times, create masks, etc. Made stub classes for other features that can be used to class-ify other aspects of the code. I still think that the API should be function-based, but this might help behind the scenes so that related information is stored together.
[RF]: MultiEchoData class
Great work Elizabeth
…On Thu, Mar 15, 2018 at 11:37 AM, Elizabeth DuPre ***@***.***> wrote:
This is a major, mostly functioning commit for starting the tedana
package, outside of meica.py.
This package was accepted as a project to Mozilla Open Leaders
<https://mozilla.github.io/leadership-training/>, so over the next few
months I'll be working both to make it better and also more open /
accessible.
As suggested by @KirstieJane <https://github.com/kirstiejane>, the first
step in making it open is to link it back to the main ME-ICA organization.
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- [RF] Initial commit of tedana module
- [RF]: MultiEchoData class
- Merge pull request #10 from rmarkello/medata_class
- get basic test working
- [ADD] tests on nifti outputs
- Update repo name for tedana
- Update branching recommendations
- Add code of conduct
- Add basic detail to README
- Initial read-the-docs commit
- Reorganize circleci config
- Add an About section
- Patch readthedocs link
File Changes
- *A* CONTRIBUTING.md
<https://github.com/ME-ICA/tedana/pull/1/files#diff-0> (81)
- *A* Code_of_Conduct.md
<https://github.com/ME-ICA/tedana/pull/1/files#diff-1> (60)
- *M* README.md <https://github.com/ME-ICA/tedana/pull/1/files#diff-2>
(42)
- *A* config.yml <https://github.com/ME-ICA/tedana/pull/1/files#diff-3>
(43)
- *A* docs/Makefile
<https://github.com/ME-ICA/tedana/pull/1/files#diff-4> (20)
- *A* docs/_static/theme_overrides.css
<https://github.com/ME-ICA/tedana/pull/1/files#diff-5> (13)
- *A* docs/conf.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-6> (180)
- *A* docs/index.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-7> (51)
- *A* docs/installation.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-8> (35)
- *A* docs/introduction.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-9> (28)
- *A* docs/make.bat
<https://github.com/ME-ICA/tedana/pull/1/files#diff-10> (36)
- *A* docs/source/meica.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-11> (53)
- *A* docs/source/meica.tests.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-12> (22)
- *A* docs/source/modules.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-13> (7)
- *A* docs/usage.rst
<https://github.com/ME-ICA/tedana/pull/1/files#diff-14> (20)
- *A* requirements.txt
<https://github.com/ME-ICA/tedana/pull/1/files#diff-15> (8)
- *A* setup.py <https://github.com/ME-ICA/tedana/pull/1/files#diff-16>
(54)
- *A* tedana/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-17> (36)
- *A* tedana/cli/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-18> (2)
- *A* tedana/cli/run.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-19> (120)
- *A* tedana/due.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-20> (67)
- *A* tedana/info.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-21> (58)
- *A* tedana/interfaces/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-22> (2)
- *A* tedana/interfaces/data.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-23> (131)
- *A* tedana/interfaces/model.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-24> (21)
- *A* tedana/interfaces/t2smap.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-25> (153)
- *A* tedana/interfaces/tedana.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-26> (1351)
- *A* tedana/tests/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-27> (2)
- *A* tedana/tests/test_tedana.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-28> (68)
- *A* tedana/utils/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-29> (2)
- *A* tedana/utils/utils.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-30> (387)
- *A* tedana/workflows/__init__.py
<https://github.com/ME-ICA/tedana/pull/1/files#diff-31> (2)
Patch Links:
- https://github.com/ME-ICA/tedana/pull/1.patch
- https://github.com/ME-ICA/tedana/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABj5UchmqR_eUTBcZ9EXPCXEnjqfK_lpks5teoq-gaJpZM4SsYax>
.
|
emdupre
pushed a commit
that referenced
this pull request
May 10, 2018
Patches: * csstepdata saved as JSON rather than a text dump * Removes unused imports in test.utils to fix linting errors
emdupre
pushed a commit
that referenced
this pull request
Sep 6, 2019
CesarCaballeroGaudes
added a commit
to smoia/tedana
that referenced
this pull request
Nov 29, 2019
Changed default compute_zvalues of get_coeffs to False
awstanton
added a commit
to awstanton/sage-tedana
that referenced
this pull request
Feb 3, 2023
Basic.simpleoptcom
notZaki
pushed a commit
to notZaki/tedana
that referenced
this pull request
Jan 26, 2024
Fix style issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major, mostly functioning commit for starting the tedana package, outside of
meica.py
.This package was accepted as a project to Mozilla Open Leaders, so over the next few months I'll be working both to make it better and also more open / accessible.
As suggested by @KirstieJane, the first step in making it open is to link it back to the main ME-ICA organization.