Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add resources to RTD site #99

Merged
merged 3 commits into from
Jul 30, 2018
Merged

[DOC] Add resources to RTD site #99

merged 3 commits into from
Jul 30, 2018

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 26, 2018

Closes #81.

Changes proposed in this pull request:

  • Change "Introduction" page to "tedana's approach"
  • Add "Multi-echo fMRI" page with sections for the physics of multi-echo fMRI, reasons to use it, and resources (including the Kundu lecture)

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   45.81%   45.81%           
=======================================
  Files          29       29           
  Lines        1602     1602           
=======================================
  Hits          734      734           
  Misses        868      868

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31504f6...074411d. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Jul 30, 2018

😍 beautiful ! Since you were also going to add some materials, @dowdlelt, it'd be great to get your review, here !

* `Multi-echo Cambridge`_
* `Multiband multi-echo imaging of simultaneous oxygenation and flow timeseries for resting state connectivity`_

.. _Multi-echo fMRI replication sample of autobiographical memory, prospection and theory of mind reasoning tasks: https://openneuro.org/datasets/ds000210/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rendering correctly ? it looks commented out on GitHub, but I'm not sure why.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @tsalo that it renders ok.

@dowdlelt
Copy link
Collaborator

I think this all looks good, though I'm entirely new to all of this. Fantastic learning experience!
I'm still lagging behind on the multiecho data table - particularly creating it in a better format, suitable for adding to docs. Perhaps this week I can make some time.

In any case, this looks like the start of something fantastic.

@emdupre
Copy link
Member

emdupre commented Jul 30, 2018

LGTM, then ! Merging, thanks ! 🎉

@emdupre emdupre merged commit 4b9687d into ME-ICA:master Jul 30, 2018
@tsalo tsalo deleted the resources branch July 30, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants