Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Flares show up in front of the Sun when they shouldn't #26

Closed
Kerbas-ad-astra opened this issue Feb 20, 2016 · 4 comments
Closed

Flares show up in front of the Sun when they shouldn't #26

Kerbas-ad-astra opened this issue Feb 20, 2016 · 4 comments
Assignees
Labels

Comments

@Kerbas-ad-astra
Copy link

I see Jool on the face of the Sun, when it's actually around the back side (ca. Year 1 Day 84).

@MOARdV MOARdV added the bug label Feb 20, 2016
@MOARdV MOARdV self-assigned this Feb 20, 2016
@MOARdV
Copy link
Owner

MOARdV commented Feb 20, 2016

Yeah, I saw that a while back. I don't know if I have any info about the size of the Sun so I can determine occlusion.

@MOARdV MOARdV added this to the v1.7 milestone Feb 20, 2016
MOARdV added a commit that referenced this issue Apr 2, 2016
Add computations to determine when the body is behind the sun.  Issue
#25 , Issue #26 .
@MOARdV MOARdV added the fixed label Apr 2, 2016
@MOARdV MOARdV closed this as completed Apr 2, 2016
@drewcassidy
Copy link

Im getting this issue with moho in version 1.7.2, ksp 1.1.3

screen shot 2016-07-02 at 12 38 03 pm

screen shot 2016-07-02 at 12 37 58 pm

@MOARdV MOARdV reopened this Jul 2, 2016
@MOARdV
Copy link
Owner

MOARdV commented Jul 2, 2016

@drewcassidy - one problem may be that the "sun" that is visible in space isn't the same size as the "sun" in the database. Short of making a hack that ignores the size of the sun, I don't know what I can do about that. Although it may be that I messed something up and the feature isn't working correctly. I will look at it.

@MOARdV MOARdV modified the milestones: v1.7.3, v1.7 Jul 2, 2016
@MOARdV MOARdV removed the fixed label Jul 2, 2016
@MOARdV MOARdV modified the milestones: v1.8.0, v1.7.3 Sep 7, 2016
@MOARdV MOARdV removed this from the v1.8.0 milestone Oct 20, 2016
@MOARdV
Copy link
Owner

MOARdV commented Nov 12, 2016

Checked the "flare in front of the sun" issue again. The problem is that the "sun" drawn in the skybox is much bigger than the radius provided in the Celestial Body (apparent size is 2x the radius of Kerbol, AFAICT). I am not going to introduce a hack to change the behavior, since it'll be entirely dependent on a stock KSP installation - something that affects sun flares would introduce a change in behavior that will generate complaints, so I'm closing this as "as good as it gets".

@MOARdV MOARdV closed this as completed Nov 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants