Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UZF variables are doubled up in the memory manager #1741

Closed
langevin-usgs opened this issue Apr 17, 2024 · 0 comments · Fixed by #1742
Closed

UZF variables are doubled up in the memory manager #1741

langevin-usgs opened this issue Apr 17, 2024 · 0 comments · Fixed by #1742
Labels
bug

Comments

@langevin-usgs
Copy link
Contributor

The following variables are checked in twice to the memory manager. The INPUT ones are being addressed as part of an IDM fix. The remaining UZF ones are outstanding and need to be addressed.

   1. Already existing variable being added to the
      MemoryMananger-__INPUT__/AUX01/CHD_0/IPER
   2. Already existing variable being added to the
      MemoryMananger-__INPUT__/AUX01/CHD_0/IONPER
   3. The well bottoms in multi-aquifer well package MAW_0 were reset to the
      bottom of the connected cell 1 times.
   4. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/HA
   5. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/HROOT
   6. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/ROOTACT
   7. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/EXTWC
   8. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/NWAV
   9. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/NTRAIL
  10. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/SINF
  11. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/GWET
  12. Already existing variable being added to the
      MemoryMananger-AUX01/UZF_0/PET
langevin-usgs added a commit to langevin-usgs/modflow6 that referenced this issue Apr 17, 2024
@langevin-usgs
fix(uzf): rename uzf package variables to avoid name clashes
d0ee9b7 
* 9 uzf variables had counterparts in uzf%uzfobj with the same memory path
* renamed the uzf package variables by adding _pvar to them
* close MODFLOW-USGS#1741

This does not fix underlying memory problems with UZF.  Instead it is a simple way to avoid multiple uzf variables with the same memory path.  A proper fix will require additional work as the variable contents in uzf and uzf%uzfobj are not the same.
@langevin-usgs langevin-usgs mentioned this issue Apr 17, 2024
Merged
langevin-usgs added a commit that referenced this issue Apr 18, 2024
@langevin-usgs
fix(uzf): rename uzf package variables to avoid name clashes (#1742)
bbcb039 
* fix(uzf): rename uzf package variables to avoid name clashes

* 9 uzf variables had counterparts in uzf%uzfobj with the same memory path
* renamed the uzf package variables by adding _pvar to them
* close #1741

This does not fix underlying memory problems with UZF.  Instead it is a simple way to avoid multiple uzf variables with the same memory path.  A proper fix will require additional work as the variable contents in uzf and uzf%uzfobj are not the same.

* fprettifying

* clean up a few variables that can be replaced with dis%top, dis%bot, and dis%area

* gwet was named to gwet_pvar

* fprettify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(uzf): rename uzf package variables to avoid name clashes langevin-usgs/modflow6
1 participant
@langevin-usgs