Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uzf): rename uzf package variables to avoid name clashes #1742

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

langevin-usgs
Copy link
Contributor

This does not fix underlying memory problems with UZF. Instead it is a simple way to avoid multiple uzf variables with the same memory path. A proper fix will require additional work as the variable contents in uzf and uzf%uzfobj are not the same.

* 9 uzf variables had counterparts in uzf%uzfobj with the same memory path
* renamed the uzf package variables by adding _pvar to them
* close MODFLOW-USGS#1741

This does not fix underlying memory problems with UZF.  Instead it is a simple way to avoid multiple uzf variables with the same memory path.  A proper fix will require additional work as the variable contents in uzf and uzf%uzfobj are not the same.
@langevin-usgs langevin-usgs merged commit bbcb039 into MODFLOW-USGS:develop Apr 18, 2024
17 checks passed
@langevin-usgs langevin-usgs deleted the fix-uzf branch April 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UZF variables are doubled up in the memory manager
2 participants