Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to scorpio 1.3.2 #359

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Update to scorpio 1.3.2 #359

merged 4 commits into from
Apr 19, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 15, 2022

E3SM was updated to this version in E3SM-Project/E3SM#4858

Because a new Spack build is required for this, the compass version has been updated to 1.1.0-alpha.2. (This should be easy to deploy because most packages will be reused from the 1.1.0-alpha.1 Spack environments.)

closes #339

@xylar xylar added enhancement New feature or request dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Apr 15, 2022
@xylar xylar self-assigned this Apr 15, 2022
@xylar
Copy link
Collaborator Author

xylar commented Apr 15, 2022

I have uploaded the Linux recipes for this version of scorpio but I don't have my Mac with me to upload those packages yet.
https://anaconda.org/e3sm/scorpio/files

@xylar
Turn on timing for scorpio because of bug
37ae401 
There is a known bug in v1.3.2 that means scorpio depends on
GPTL even when timing is off.  The easiest fix for now is to turn
on timing and bring in this dependency.
@pep8speaks
Copy link

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 308:80: E501 line too long (86 > 79 characters)

xylar
xylar commented Apr 15, 2022
View reviewed changes
conda/bootstrap.py
specs.append(f'scorpio@{scorpio}+pnetcdf~timing+internal-timing~tools+malloc')
specs.append(f'scorpio@{scorpio}+pnetcdf+timing+internal-timing~tools+malloc')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm turning on timing for now. In future scorpio versions, we can decide if we want it turned off but it's required in this one because of a known bug (E3SM-Project/scorpio#476)

@xylar xylar merged commit 679a518 into MPAS-Dev:master Apr 19, 2022
@xylar xylar deleted the scorpio_1.3.2 branch April 19, 2022 16:04
@xylar
Copy link
Collaborator Author

xylar commented Apr 20, 2022

Shoot! I did a bunch of testing before merging this but now I'm seeing bunches of errors when I build MPAS-Ocean and MALI:

...
/tmp/ac.xylar/spack-stage/spack-stage-scorpio-1.3.2-jwtpz3glryifs7okeohvaynxm3dbuosx/spack-build-jwtpz3g/src/flib//tmp/ac.xylar/spack-stage/spack-stage-scorpio-1.3.2-jwtpz3glryifs7okeohvaynxm3dbuosx/spack-src/src/flib/piodarray.F90.in:388: undefined reference to `perf_mod_mp_t_startf_'
/tmp/ac.xylar/spack-stage/spack-stage-scorpio-1.3.2-jwtpz3glryifs7okeohvaynxm3dbuosx/spack-build-jwtpz3g/src/flib//tmp/ac.xylar/spack-stage/spack-stage-scorpio-1.3.2-jwtpz3glryifs7okeohvaynxm3dbuosx/spack-src/src/flib/piodarray.F90.in:396: undefined reference to `perf_mod_mp_t_stopf_'
/lcrc/soft/climate/compass/anvil/spack/spack_for_mache_1.3.2/var/spack/environments/dev_compass_1_1_0-alpha_2_intel_impi/.spack-env/view/lib/libpioc.a(pioc.c.o): In function `PIOc_finalize':
/tmp/ac.xylar/spack-stage/spack-stage-scorpio-1.3.2-jwtpz3glryifs7okeohvaynxm3dbuosx/spack-src/src/clib/pioc.c:1511: undefined reference to `GPTLpr_summary_file'
make[1]: *** [mpas] Error 1

I don't know what is different but I suspect that there's something wrong with linking when we have scorpio+timing from Spack. I'll try to fix it ASAP.

@xylar xylar mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to scorpio 1.3.2
2 participants
@xylar @pep8speaks